update libgd to latest commit #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Dec 14, 2023
packages/l/libgd/xmake.lua
Outdated
| @@ -31,9 +34,13 @@ package("libgd") | |||
| package:add("defines", "BGDWIN32") | |||
| package:add("defines", "NONDLL") | |||
| end | |||
There was a problem hiding this comment.
上面不是已经有 NODLL 配置了么。直接 package:is_plat("windows", "mingw") 不就好了
waruqi
reviewed
Dec 14, 2023
| @@ -31,9 +34,13 @@ package("libgd") | |||
| package:add("defines", "BGDWIN32") | |||
| package:add("defines", "NONDLL") | |||
| end | |||
| if package:is_plat("mingw") and not package:config("shared") then | |||
| package:add("defines", "BGDWIN32") | |||
| package:add("defines", "NONDLL") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgd仓库一直在更新，只是两年没有发版本了
顺便放开mingw的支持