Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release mode 中 NDEBUG 也应该为cuflags添加 #5632

Closed
cherichy opened this issue Sep 18, 2024 · 3 comments · Fixed by #5633
Closed

release mode 中 NDEBUG 也应该为cuflags添加 #5632

cherichy opened this issue Sep 18, 2024 · 3 comments · Fixed by #5633

Comments

@cherichy
Copy link
Contributor

你在什么场景下需要该功能?

目前在rules/mode/xmake.lua中NDEBUG加在cxflags中,对cuda程序而言这个flag就没有作用

描述可能的解决方案

在target:add("cxflags", "-DNDEBUG")之后添加target:add("cuflags", "-DNDEBUG")

描述你认为的候选方案

No response

其他信息

No response

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Title: release mode NDEBUG should also be added for cuflags

In what scenario do you need this function?

Currently, NDEBUG is added to cxflags in rules/mode/xmake.lua. This flag has no effect on the cuda program.

Describe possible solutions

Add target:add("cuflags", "-DNDEBUG") after target:add("cxflags", "-DNDEBUG")

Describe your alternatives

No response

Other information

No response

@waruqi
Copy link
Member

waruqi commented Sep 18, 2024

来个 pr 过来

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Come here for a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants