Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modules support #4673

Merged
merged 149 commits into from
Feb 18, 2024
Merged

Refactor modules support #4673

merged 149 commits into from
Feb 18, 2024

Conversation

waruqi
Copy link
Member

@waruqi waruqi commented Feb 2, 2024

by not preprocess #include <stlheader> to make preprocessed file smaller to parse
to keep syntax coloration of clang / cl output when compiling modules
seems my refactoring doesn't prevent this policy to work fine
@waruqi
Copy link
Member Author

waruqi commented Feb 10, 2024

#4727

Modules incremental compilation does not work.

@Arthapz
Copy link
Member

Arthapz commented Feb 10, 2024

I don't have much Time today, so i'll check tomorrow

@Arthapz
Copy link
Member

Arthapz commented Feb 10, 2024

i may have fixed incremental compilation in my module reuse PR #4728, so i'll create the PR, but it is based on #4707

@waruqi
Copy link
Member Author

waruqi commented Feb 15, 2024

i may have fixed incremental compilation in my module reuse PR #4728, so i'll create the PR, but it is based on #4707

packages test does not work.

ruki@0d35ffa77272:/mnt/xmake/tests/projects/c++/modules/packages$ xmake
[ 22%]: <packages> compiling.module.release bar
[ 22%]: <packages> compiling.module.release foo
[ 22%]: <packages> compiling.module.release bar2
[ 66%]: compiling.release src/main.cpp
[ 77%]: linking.release packages
[100%]: build ok, spent 1.373s
ruki@0d35ffa77272:/mnt/xmake/tests/projects/c++/modules/packages$ xmake
[ 22%]: <packages> compiling.module.release bar2
[ 22%]: <packages> compiling.module.release foo
[ 22%]: <packages> compiling.module.release bar
[ 66%]: compiling.release src/main.cpp
[ 77%]: linking.release packages
[100%]: build ok, spent 1.381s

@waruqi waruqi mentioned this pull request Feb 18, 2024
@waruqi waruqi merged commit 3c1163b into dev Feb 18, 2024
38 checks passed
@waruqi waruqi deleted the modules branch February 18, 2024 13:41
@waruqi waruqi mentioned this pull request Feb 18, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants