Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Inconsistent Return for getDmByInboxId Compared to list() #768

Open
palket opened this issue Jan 4, 2025 · 1 comment
Open

Bug: Inconsistent Return for getDmByInboxId Compared to list() #768

palket opened this issue Jan 4, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@palket
Copy link

palket commented Jan 4, 2025

Describe the bug

When using the XMTP browser-sdk, we noticed an inconsistency between the objects returned by getDmByInboxId and those returned by list(). Specifically, getDmByInboxId does not return Conversation objects that include the dmPeerInboxId method, whereas objects from list() do. This behavior causes issues when trying to use the dmPeerInboxId method on conversations fetched by getDmByInboxId.

Expected behavior

Both methods (list() and getDmByInboxId) should return Conversation objects with the same structure, including the dmPeerInboxId method.

Steps to reproduce the bug

  1. Use xmtpClient.conversations.list() to fetch all conversations.
  2. Verify that the returned objects have the dmPeerInboxId method.
  3. Use xmtpClient.conversations.getDmByInboxId(inboxId) with a valid inbox ID.
  4. Check the returned object for the dmPeerInboxId method.
@palket palket added the bug Something isn't working label Jan 4, 2025
@rygine
Copy link
Collaborator

rygine commented Jan 6, 2025

@palket i've tested this locally and it works as expected.

i think you may be using an older version of the Browser SDK. please upgrade to the latest and let us know if you're still experiencing the issue.

@rygine rygine assigned rygine and unassigned codabrink Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants