Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize DCS put/unhook #1909

Closed
jerch opened this issue Jan 25, 2019 · 1 comment
Closed

optimize DCS put/unhook #1909

jerch opened this issue Jan 25, 2019 · 1 comment
Assignees
Labels
area/parser type/enhancement Features or improvements to existing features

Comments

@jerch
Copy link
Member

jerch commented Jan 25, 2019

Currently the DCS handling of the parser works in 3 different steps:

  • HOOK: activates a certain subparser and announces escape sequence parameters to it
  • PUT: payload for the subparser, might be called multiple times with payload chunks
  • UNHOOK: tells the subparser thats the DCS command is about to finish

Currently all DCS commands we support have rather short payload and their parsers do their business in unhook. This leads to unnecessary data copy of the last payload chunk, that cannot be evaluated before unhooking.

Solution: Skip PUT for the last payload chunk and transfer it with UNHOOK directly.

@jerch jerch added type/enhancement Features or improvements to existing features area/parser labels Jan 25, 2019
@jerch jerch self-assigned this Jan 25, 2019
This was referenced Jun 1, 2019
@jerch
Copy link
Member Author

jerch commented Jul 25, 2019

Closing this issue as it will not save much, but make the parser much more complicated.

@jerch jerch closed this as completed Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/parser type/enhancement Features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant