Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons and CSS missing from the master build #2178

Closed
Eugeny opened this issue Jun 3, 2019 · 3 comments
Closed

Addons and CSS missing from the master build #2178

Eugeny opened this issue Jun 3, 2019 · 3 comments
Labels
type/question A question on how to use the library

Comments

@Eugeny
Copy link
Member

Eugeny commented Jun 3, 2019

See above - it looks like the addons might be published each separately in the future?

@Tyriar
Copy link
Member

Tyriar commented Jun 3, 2019

Yes we pushed in #2164 but have not yet published the addon modules from that, you can probably still use the published xterm-addon-attach, xterm-addon-search and xterm-addon-web-links which were based on the now archived repos.

Let me know if that doesn't work and I'll prioritize #2165 a little higher.

@Tyriar Tyriar closed this as completed Jun 3, 2019
@Tyriar Tyriar added the type/question A question on how to use the library label Jun 3, 2019
@tsl0922
Copy link
Contributor

tsl0922 commented Jun 15, 2019

Hi, @Tyriar

The published [email protected] doesn't work for me.

Probably caused by the main field in package.json, it should be lib/WebLinksAddon.js.

{
  "name": "xterm-addon-web-links",
  "version": "0.1.0-beta1",
  "main": "webLinksAddon.ts",
  "scripts": {
    "watch": "tsc -w"
  },
  "devDependencies": {
    "typescript": "^3.2.2",
    "xterm": "^3.10.0"
  },
  "peerDependencies": {
    "xterm": "^3.10.0"
  }
}

@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2019

@tsl0922 I accidentally published that under the latest tag, npm i xterm-addon-web-links@beta should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question A question on how to use the library
Projects
None yet
Development

No branches or pull requests

3 participants