-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proposal] v2.0.0 goals #248
Comments
I think the rewriting should be done slowly over time, not necessarily commit to "rewrite the code base" for v2.0.0. A large portion of the code is quite a mess right now and we certainly shouldn't rush any refactors. |
Part of my thinking here is that master should always be shippable, I say this largely because vscode doesn't currently ship a tagged release but an arbitrary commit. So the longer xterm.js goes without a release the more risk is associated with the vscode terminal essentially. Also it gets plenty of testings via vscode so frequent smaller releases are possible (and shipping often is good). |
+1 to vanilla js and native css 'cause i hope xterm.js to be standard :) |
It would be better if we didn't see 2.0 as a "big release" but just as an API breakage point, because we have to split the core into multiple files (#158). I would restrain on adding any other goals in this release. I agree with @Tyriar that rewrites should happen slowly and gradually and I will add that everything we do has to be purposeful. For example, we should switch to a CSS preprocessor only if it makes sense for xterm.js. Right now there is no open issue for discussion this, so I do not find any reason to squeeze it into the 2.0 release. Last, I will agree with @Tyriar again that the |
Closing the issue since it doesn't fit the versioning strategy. |
This is just a quick collection of ideas that popped up in older issues and might be worth targeting with a 2.0.0 release. Some of them are fundamental and need a proper design decision.
Up for discussion - feel free to add other ideas or edit the list.
Details
The text was updated successfully, but these errors were encountered: