Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search highlights don't work in the alt buffer #3918

Closed
alanhe421 opened this issue Jul 22, 2022 · 1 comment · Fixed by #3924
Closed

Search highlights don't work in the alt buffer #3918

alanhe421 opened this issue Jul 22, 2022 · 1 comment · Fixed by #3924
Labels
area/addon/search help wanted type/bug Something is misbehaving

Comments

@alanhe421
Copy link

alanhe421 commented Jul 22, 2022 •
edited
Loading

run vi command
image

run cat command
image

hightlight nor work in vi mode

Details

  • Browser and browser version: Chrome v103.0.5060.134
  • OS version: Big Sur 11.6.7
  • xterm.js version: v4.19.0
    xterm-addon-search v0.10.0-beta.3

Steps to reproduce
@Tyriar Tyriar added type/bug Something is misbehaving area/addon/search labels Jul 22, 2022
@Tyriar
Copy link
Member

Tyriar commented Jul 22, 2022

Was an oversight to not do the decorations in the alt buffer as well, thanks for reporting.

@Tyriar Tyriar changed the title search highlight not work in vi mode Search highlights don't work in the alt buffer Jul 22, 2022
@silamon silamon mentioned this issue Jul 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/addon/search help wanted type/bug Something is misbehaving
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow markers on the alt buffer silamon/xterm.js
2 participants
@Tyriar @alanhe421