Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canvas renderer curly underline is cut off #4653

Closed
Tyriar opened this issue Aug 9, 2023 · 1 comment · Fixed by #4664
Closed

canvas renderer curly underline is cut off #4653

Tyriar opened this issue Aug 9, 2023 · 1 comment · Fixed by #4664
Assignees
@Tyriar
Labels
area/addon/canvas good first issue help wanted type/bug Something is misbehaving
Milestone
5.3.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 9, 2023

This is tracking #4476 but for curly, where curly is dashed on canvas as it's cut off.

Related: #4064
@Tyriar Tyriar mentioned this issue Aug 9, 2023
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Aug 9, 2023

This needs to adopt the restrict arg like in #4648, ideally with a generic solution that applies to all underlines

@Tyriar Tyriar mentioned this issue Aug 9, 2023
Merged
@tisilent tisilent mentioned this issue Aug 11, 2023
Merged
@Tyriar Tyriar added this to the 5.3.0 milestone Aug 11, 2023
@Tyriar Tyriar self-assigned this Aug 11, 2023
@Tyriar Tyriar mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/canvas good first issue help wanted type/bug Something is misbehaving
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

Fix canvas underline is cut off. tisilent/xterm.js
1 participant
@Tyriar