Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases are not built - Travis deployment bug #1054

Closed
roborourke opened this issue Mar 17, 2020 · 2 comments · Fixed by #1057
Closed

Releases are not built - Travis deployment bug #1054

roborourke opened this issue Mar 17, 2020 · 2 comments · Fixed by #1057

Comments

@roborourke
Copy link

Bug Report

Looking at the Travis CI config it appears that the deploy section is intended to update the released tags on Github with the built version. Fetching the plugin via composer right now requires an additional build step.

deploy:
  provider: releases
  overwrite: true
  skip_cleanup: true
  file_glob: true
  file: build/**/*
  on:
    tags: true

# Pull requests are built by default.
branches:
  only:
  - master
  - develop

The problem is that by using branches: only builds only happen on these branches, tags are excluded so by setting deploy: on: tags: true this effectively means the deploy step can never run.

I would recommend either removing the branches section entirely or adding a regex to match your tag structure to that list.

Expected Behavior

Travis should build and deploy when the repo is tagged.

Actual Behavior

Travis does nothing, tag represents unbuilt commit.

@roborourke roborourke changed the title Releases are not built - Travis release deployment bug Releases are not built - Travis deployment bug Mar 17, 2020
@kasparsd
Copy link
Contributor

Thank you for opening the issue!

Looks like we never got the Travis CI to create the plugin bundles and upload them to GitHub releases. I'm not even sure the current deploy workflow for releases would work because it doesn't create a ZIP file which is expected by that deploy workflow.

We would probably want to add a dedicated release command to scripts in package.json which does the build and creates a zip file out of that directory. This would also need a dedicated Grunt task to zip it.

@roborourke
Copy link
Author

Ah I see, I thought it maybe just pushed the built directory to the tag. Thanks @kasparsd !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants