From 804181600d089d7b8364114dcb47e0393908d214 Mon Sep 17 00:00:00 2001 From: Junhao Liao Date: Mon, 30 Dec 2024 23:48:20 -0500 Subject: [PATCH 1/3] fix(filter): Introduce mono font styling for LogLevelChip with Roboto Mono fallback (fixes #154). (#156) --- public/index.html | 2 ++ src/components/StatusBar/LogLevelSelect/LogLevelChip.css | 3 +++ src/index.css | 2 ++ 3 files changed, 7 insertions(+) diff --git a/public/index.html b/public/index.html index 0ea29173..5a2821d2 100644 --- a/public/index.html +++ b/public/index.html @@ -11,6 +11,8 @@ +
diff --git a/src/components/StatusBar/LogLevelSelect/LogLevelChip.css b/src/components/StatusBar/LogLevelSelect/LogLevelChip.css index 8a70ba6c..c9fa8c2e 100644 --- a/src/components/StatusBar/LogLevelSelect/LogLevelChip.css +++ b/src/components/StatusBar/LogLevelSelect/LogLevelChip.css @@ -1,6 +1,9 @@ .log-level-chip { /* stylelint-disable-next-line custom-property-pattern */ --Chip-radius: 0; + + font-family: var(--ylv-ui-mono-font-family), monospace !important; + font-weight: 600 !important; } .log-level-chip span { diff --git a/src/index.css b/src/index.css index 815b9bd2..0e2fe4a2 100644 --- a/src/index.css +++ b/src/index.css @@ -14,6 +14,8 @@ html { /* font-family globals */ --ylv-ui-font-family: -apple-system, "BlinkMacSystemFont", system-ui, "Ubuntu", "Droid Sans", "Inter"; + --ylv-ui-mono-font-family: "SF Mono", monaco, menlo, "Ubuntu Mono", "Liberation Mono", + "DejaVu Sans Mono", "Roboto Mono"; /* size globals */ --ylv-status-bar-height: 32px; From 5a3bd105599b9c1861487bc217615b50e785e15e Mon Sep 17 00:00:00 2001 From: Junhao Liao Date: Mon, 6 Jan 2025 14:12:34 -0500 Subject: [PATCH 2/3] ci: Set "persist-credentials" to false for all GH `actions/checkout`. (#162) --- .github/workflows/deploy-gh-pages.yaml | 1 + .github/workflows/lint.yaml | 1 + .github/workflows/test.yaml | 1 + 3 files changed, 3 insertions(+) diff --git a/.github/workflows/deploy-gh-pages.yaml b/.github/workflows/deploy-gh-pages.yaml index dd1f139a..49f6a862 100644 --- a/.github/workflows/deploy-gh-pages.yaml +++ b/.github/workflows/deploy-gh-pages.yaml @@ -18,6 +18,7 @@ jobs: steps: - uses: "actions/checkout@v4" with: + persist-credentials: false submodules: "recursive" - uses: "actions/setup-node@v4" diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index e9d494a9..e5a16f15 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -27,6 +27,7 @@ jobs: steps: - uses: "actions/checkout@v4" with: + persist-credentials: false submodules: "recursive" - uses: "actions/setup-node@v4" with: diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index e6efb5db..c5afc446 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -23,6 +23,7 @@ jobs: steps: - uses: "actions/checkout@v4" with: + persist-credentials: false submodules: "recursive" - uses: "actions/setup-node@v4" with: From 5b368b9530d6fbfcdc42343b2f356c6f43bffcad Mon Sep 17 00:00:00 2001 From: Junhao Liao Date: Mon, 6 Jan 2025 15:07:40 -0500 Subject: [PATCH 3/3] fix(filter): Set max height for the log-level listbox and refine styling (fixes #150). (#155) --- src/components/StatusBar/LogLevelSelect/index.css | 3 +-- src/components/StatusBar/LogLevelSelect/index.tsx | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/components/StatusBar/LogLevelSelect/index.css b/src/components/StatusBar/LogLevelSelect/index.css index 9e17673e..da2e8831 100644 --- a/src/components/StatusBar/LogLevelSelect/index.css +++ b/src/components/StatusBar/LogLevelSelect/index.css @@ -21,8 +21,7 @@ } .log-level-select-listbox { - /* Disallow width auto-resizing with the `Select` button. */ - max-width: 0; + max-height: calc(100vh - var(--ylv-menu-bar-height) - var(--ylv-status-bar-height)) !important; } .log-level-select-option-text-tooltip { diff --git a/src/components/StatusBar/LogLevelSelect/index.tsx b/src/components/StatusBar/LogLevelSelect/index.tsx index fe0db3fc..92ca870f 100644 --- a/src/components/StatusBar/LogLevelSelect/index.tsx +++ b/src/components/StatusBar/LogLevelSelect/index.tsx @@ -259,6 +259,13 @@ const LogLevelSelect = () => { listbox: { className: "log-level-select-listbox", placement: "top-end", + modifiers: [ + // Disallow listbox width auto-resizing with the `Select` button. + {name: "equalWidth", enabled: false}, + + // Remove gap between the listbox and the `Select` button. + {name: "offset", enabled: false}, + ], }, }} >