Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text dominant-baseline not working #80

Open
belst opened this issue May 2, 2019 · 1 comment · Fixed by stasdavydov/svg2pdf.js#1 · May be fixed by #286
Open

text dominant-baseline not working #80

belst opened this issue May 2, 2019 · 1 comment · Fixed by stasdavydov/svg2pdf.js#1 · May be fixed by #286
Labels
difficulty:medium enhancement Hacktoberfest help wanted Help with creating a proper test-case, looking up the spec, or creating a pull request.

Comments

@belst
Copy link

belst commented May 2, 2019

Describe the bug
I am using dominant-baseline="central" to vertically center some text.
This works fine in the svg, but not in the generated pdf.

Screenshots
SVG: svg

PDF: pdf

Desktop (please complete the following information):
Chromium Version 74.0.3729.131 (Official Build) Arch Linux (64-Bit)
@HackbrettXXX
Copy link
Member

You're right, this is not supported by svg2pdf. We don't plan on implementing this by ourselves. We are happy about a pull request, though.

@HackbrettXXX HackbrettXXX added enhancement help wanted Help with creating a proper test-case, looking up the spec, or creating a pull request. labels May 2, 2019
@yGuy yGuy mentioned this issue Sep 5, 2019
Closed
@yGuy yGuy mentioned this issue Nov 9, 2020
Open
giroletm added a commit to giroletm/svg2pdf.js that referenced this issue May 7, 2024
@giroletm
Use dominant-baseline if alignment-baseline is missing (yWorks#80) & …
2884808 
…ctx fix

Fixes yWorks#80
Applies the current context before rendering a text node
@giroletm giroletm linked a pull request May 7, 2024 that will close this issue
Draft
@stasdavydov stasdavydov mentioned this issue May 17, 2024
Merged
stasdavydov added a commit to stasdavydov/svg2pdf.js that referenced this issue May 17, 2024
@stasdavydov
Merge pull request #1 from giroletm/master
82e222a 
Use dominant-baseline if alignment-baseline is missing (yWorks#80) & ctx fix
HackbrettXXX pushed a commit to giroletm/svg2pdf.js that referenced this issue Feb 12, 2025
@giroletm @HackbrettXXX
Use dominant-baseline if alignment-baseline is missing (yWorks#80) & …
174b7dc 
…ctx fix

Fixes yWorks#80
Applies the current context before rendering a text node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:medium enhancement Hacktoberfest help wanted Help with creating a proper test-case, looking up the spec, or creating a pull request.
Projects
None yet
Milestone
No milestone
2 participants
@belst @HackbrettXXX