Fix test script to run on Windows #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows had some trouble getting to the Istanbul CLI and finding the right Mocha script. This variation of the test script should work on all platforms
|
+1 |
|
Won't this require Istanbul to be installed globally? Also will this work in CI on Screwdriver? |
|
node will rely on |
ericf
added a commit
that referenced
this pull request
Nov 25, 2013
Fix test script to run on Windows
|
Yeah it worked fine on Screwdriver. I'll now merge the other ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows had some trouble getting to the Istanbul CLI and finding the right Mocha script. This variation of the test script should work on all platforms.