Create extend() API so any Express module instance can be extended
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only the the Express module instance which is a `peerDependency` of this package would be extended with this package's functionality. This now exports the `extend()` function which allows any Express module instance to be extended.
|
@caridy and @redonkulus is this what you were looking for to be able to extend any Express module instance, not just the Express module instance which is a |
|
Yeah, that will work. Can we get |
|
LGTM |
ericf
added a commit
that referenced
this pull request
Jul 29, 2013
Create `extend()` API so any Express module instance can be extended
|
published in [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the the Express module instance which is a
peerDependencyof this package would be extended with this package's functionality. This now exports theextend()function which allows any Express module instance to be extended.Todo
augment()is safe forresProto, it might be shared between apps