-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows ARM64 Builds #11915
Windows ARM64 Builds #11915
Conversation
Possible way to test this:
Since windows works the same way. The only difference for ARM builds would be the JRE that we shipped. Thus if it works with appropriate JRE link in our system, we can be sure that it would work with appropriate JRE in Windows ARM64. |
Now, the remaining test would be to see if this correctly adds |
Is there a reason not to use packr? This looks exactly like what packr does, we could just change the JDK in between x86 and ARM builds |
If we see that doesn't work we can try this but it seems unnecessary if the current path will suffice |
Hmm... They officially does not support ARM yet... But ARM devices can emulate x64 code so this might work... But again not sure how to test this, also not sure how to configure packr... |
theoretically just replace the existing "windows 64 bit" JDK in the CI flow with your JDK and it'll use that one |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
resolves #11909
Unciv.bat
runs Unciv properly