Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build roads on NW #11925

Closed
1 task done
hackedpassword opened this issue Jul 7, 2024 · 7 comments
Closed
1 task done

Unable to build roads on NW #11925

hackedpassword opened this issue Jul 7, 2024 · 7 comments

Comments

@hackedpassword
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Game Version

4.12.7

Describe the bug

Some time ago, I recall a change made where roads could no longer be made on Natural Wonders. Didn't want to complain and see how things evolved.

Steps to Reproduce

I've scoured release descriptions for the last year, didn't find a definitive hit. Went through code history for the below file (my good guess this is probably right) still nothing solid.
https://github.com/yairm210/Unciv/commits/master/core/src/com/unciv/logic/map/tile/TileImprovementFunctions.kt

The change affected mod Z2 as roads could be built across NW bridges until this alleged modification. Questioning my recollection of the change since I can't seem to find evidence of it.

Screenshots

No response

Link to save file

No response

Operating System

Android

Additional Information

Doesn't appear to be related to terrain or improvement jsons or uniques. Map editor allows laying down roads on NW's.

Railroads are implied with roads.

Did that change actually happen? If so is this something that can be reconsidered?

@yairm210
Copy link
Owner

yairm210 commented Jul 7, 2024

I don't recall this ever being possible
Base ruleset's natural wonders are impassible so this never cropped up

@hackedpassword
Copy link
Author

Really. Yep, it was possible! :D

The last known instance via screenshots I have is Dec 1 2023. See the bridge tiles, comprised of 4 total NW's (bridge1&2 coast&ocean)

Screenshot_20231201-021609_Unciv

Somewhere in Nov-Dec, is where a really nasty crash showed itself (#10613 Nov 28) and I switched gears for a while til SeventhM solved this via #11352 Mar 21. I can't be exactly sure atm but amidst that could be why I didn't address the issue then.

@hackedpassword
Copy link
Author

When I have time I'm tracing Unciv versions to isolate where a change would have happened. So far looking at about the 4.8-4.9 era.

@SomeTroglodyte
Copy link
Collaborator

I'm pretty sure this depends only on the unbuildable property, and always has.
image
Modded to remove unbuildable and impassable - so the Worker can go there - from all vanilla NW, that's all.

@hackedpassword
Copy link
Author

Switched up the bridge tiles to:

		"unbuildable": false,

As well as commenting those two lines out, no effect on build-ability.

Tried adding terrainFeature "Force" to the roads:

		"name": "Railroad",
		"terrainsCanBeBuiltOn": ["Land","Natural Wonder","Force"],  // originally Land only, then w/ NW, then +Force

If I force a builder unit to construct Connect road while on the bridge tile, construction will activate, turns do not decrement, builder remains building forever.

Still have to spend time on version assessment.

Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Oct 16, 2024
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants