Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command 'wait' is not translatable #7019

Closed
heipizhu4 opened this issue May 31, 2022 · 3 comments
Closed

Command 'wait' is not translatable #7019

heipizhu4 opened this issue May 31, 2022 · 3 comments
Labels
bug

Comments

@heipizhu4
Copy link
Contributor

Version
4.0.12 - current version

Describe the bug
The command 'wait' implemmented in #6896 isn't able to translate.

To Reproduce
Go to template.properties and search Wait = and you'll know it's not translatable.

Additional context
Already made a simple attempt in #7006, and it failed (as expected).
@heipizhu4 heipizhu4 added the bug label May 31, 2022
@Mape6
Copy link
Contributor

Mape6 commented May 31, 2022

Maybe your branch is too old. 4.0.12 is not the current version. Unciv is already at 4.1.5
What if you create a new branch with a fresh pull from Unciv master and then create the PR?

@Mape6
Copy link
Contributor

Mape6 commented May 31, 2022

I created a new PR, lets wait what happens
#7021

@heipizhu4 heipizhu4 mentioned this issue May 31, 2022
Merged
@JackRainy
Copy link
Collaborator

Closed by #7021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JackRainy @Mape6 @heipizhu4