Fix sort-comp bad error message (fixes #507)

jsx-eslint · Nov 6, 2016 · 8515667 · 8515667
1 parent d88ee37
commit 8515667
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/lib/rules/sort-comp.js b/lib/rules/sort-comp.js
@@ -217,6 +217,10 @@ module.exports = {
       }
       // Increment the prop score
       errors[propA.index].score++;
+      // Stop here if we already have pushed another node at this position
+      if (getPropertyName(errors[propA.index].node) !== getPropertyName(propA.node)) {
+        return;
+      }
       // Stop here if we already have a closer reference
       if (Math.abs(propA.index - propB.index) > errors[propA.index].closest.distance) {
         return;

diff --git a/tests/lib/rules/sort-comp.js b/tests/lib/rules/sort-comp.js
@@ -378,5 +378,28 @@ ruleTester.run('sort-comp', rule, {
         'render'
       ]
     }]
+  }, {
+    code: [
+      'export default class View extends React.Component {',
+      '  componentDidMountOk() {}',
+      '  getB() {}',
+      '  componentWillMount() {}',
+      '  getA() {}',
+      '  render() {}',
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    errors: [{message: 'componentDidMountOk should be placed after getA'}],
+    options: [{
+      order: [
+        'static-methods',
+        'lifecycle',
+        '/^on.+$/',
+        '/^(get|set)(?!(InitialState$|DefaultProps$|ChildContext$)).+$/',
+        'everything-else',
+        '/^render.+$/',
+        'render'
+      ]
+    }]
   }]
 });