From f4aea2024ce57274c71f4e62293a054837c99ad4 Mon Sep 17 00:00:00 2001
From: Thomas Dy <thatsmydoing@gmail.com>
Date: Fri, 2 Jun 2023 10:08:07 +0900
Subject: [PATCH] test: ensure symlink zips work

---
 .../sources/commands/install.test.ts          |  27 ++++++++++++++++++
 .../pkg-tests-specs/sources/pnp.test.js       |  27 ++++++++++++++++++
 .../yarnpkg-libzip/tests/ZipOpenFS.test.ts    |  13 +++++++++
 .../tests/fixtures/symlink-source.zip         | Bin 0 -> 154 bytes
 .../yarnpkg-libzip/tests/fixtures/symlink.zip |   1 +
 5 files changed, 68 insertions(+)
 create mode 100644 packages/yarnpkg-libzip/tests/fixtures/symlink-source.zip
 create mode 120000 packages/yarnpkg-libzip/tests/fixtures/symlink.zip

diff --git a/packages/acceptance-tests/pkg-tests-specs/sources/commands/install.test.ts b/packages/acceptance-tests/pkg-tests-specs/sources/commands/install.test.ts
index f9bbf062f888..6135752f4fb0 100644
--- a/packages/acceptance-tests/pkg-tests-specs/sources/commands/install.test.ts
+++ b/packages/acceptance-tests/pkg-tests-specs/sources/commands/install.test.ts
@@ -109,6 +109,33 @@ describe(`Commands`, () => {
       }),
     );
 
+    tests.testIf(
+      () => process.platform !== `win32`,
+      `it should install from zips that are symlinks`,
+      makeTemporaryEnv({
+        dependencies: {
+          [`no-deps`]: `1.0.0`,
+        },
+      }, async ({path, run, source}) => {
+        await run(`install`);
+
+        const allFiles = await xfs.readdirPromise(ppath.join(path, `.yarn/cache`));
+        const zipFiles = allFiles.filter(file => file.endsWith(`.zip`));
+
+        await xfs.mkdirPromise(ppath.join(path, `store`));
+        for (const filename of zipFiles) {
+          const zipFile = ppath.join(path, `.yarn/cache`, filename);
+          const storePath = ppath.join(path, `store`, filename);
+          await xfs.movePromise(zipFile, storePath);
+          await xfs.symlinkPromise(storePath, zipFile);
+        }
+
+        await xfs.removePromise(ppath.join(path, Filename.pnpCjs));
+
+        await run(`install`, `--immutable`);
+      }),
+    );
+
     test(
       `it should refuse to create a lockfile when using --immutable`,
       makeTemporaryEnv({
diff --git a/packages/acceptance-tests/pkg-tests-specs/sources/pnp.test.js b/packages/acceptance-tests/pkg-tests-specs/sources/pnp.test.js
index 4560f72b5542..11a8e560fd88 100644
--- a/packages/acceptance-tests/pkg-tests-specs/sources/pnp.test.js
+++ b/packages/acceptance-tests/pkg-tests-specs/sources/pnp.test.js
@@ -2252,4 +2252,31 @@ describe(`Plug'n'Play`, () => {
       });
     }),
   );
+
+  testIf(
+    () => process.platform !== `win32`,
+    `it can resolve files from zips that are symlinks`,
+    makeTemporaryEnv({
+      dependencies: {
+        [`no-deps`]: `1.0.0`,
+      },
+    }, async ({path, run, source}) => {
+      await run(`install`);
+
+      const allFiles = await xfs.readdirPromise(ppath.join(path, `.yarn/cache`));
+      const zipFiles = allFiles.filter(file => file.endsWith(`.zip`));
+
+      await xfs.mkdirPromise(ppath.join(path, `store`));
+      for (const filename of zipFiles) {
+        const zipFile = ppath.join(path, `.yarn/cache`, filename);
+        const storePath = ppath.join(path, `store`, filename);
+        await xfs.movePromise(zipFile, storePath);
+        await xfs.symlinkPromise(storePath, zipFile);
+      }
+
+      await expect(
+        source(`require('no-deps')`),
+      ).resolves.toEqual({name: `no-deps`, version: `1.0.0`});
+    }),
+  );
 });
diff --git a/packages/yarnpkg-libzip/tests/ZipOpenFS.test.ts b/packages/yarnpkg-libzip/tests/ZipOpenFS.test.ts
index 216251432aef..a1e7e3386dc3 100644
--- a/packages/yarnpkg-libzip/tests/ZipOpenFS.test.ts
+++ b/packages/yarnpkg-libzip/tests/ZipOpenFS.test.ts
@@ -13,10 +13,15 @@ export const ZIP_DIR3 = ppath.join(
   npath.toPortablePath(__dirname),
   `fixtures/foo.hiddenzip` as Filename,
 );
+export const ZIP_DIR4 = ppath.join(
+  npath.toPortablePath(__dirname),
+  `fixtures/symlink.zip` as Filename,
+);
 
 export const ZIP_FILE1 = ppath.join(ZIP_DIR1, `foo.txt`);
 export const ZIP_FILE2 = ppath.join(ZIP_DIR2, `foo.txt`);
 export const ZIP_FILE3 = ppath.join(ZIP_DIR3, `foo.txt`);
+export const ZIP_FILE4 = ppath.join(ZIP_DIR4, `foo.txt`);
 
 afterEach(() => {
   jest.useRealTimers();
@@ -81,6 +86,14 @@ describe(`ZipOpenFS`, () => {
     fs.discardAndClose();
   });
 
+  it(`can read from a zip file that's a symlink`, () => {
+    const fs = new ZipOpenFS();
+
+    expect(fs.readFileSync(ZIP_FILE4, `utf8`)).toEqual(`foo\n`);
+
+    fs.discardAndClose();
+  });
+
   it(`doesn't close a ZipFS instance with open handles`, () => {
     const fs = new ZipOpenFS({maxOpenFiles: 1});
 
diff --git a/packages/yarnpkg-libzip/tests/fixtures/symlink-source.zip b/packages/yarnpkg-libzip/tests/fixtures/symlink-source.zip
new file mode 100644
index 0000000000000000000000000000000000000000..b93c88559ed342fc378d682fd2c8e391bf7df63d
GIT binary patch
literal 154
zcmWIWW@Zs#U|`^2h?;&WU`47?9UG9x0>tb<oR*)jS5i^pefs=!CWZiSMkaX%T#8kI
x%0WN@Ov1HtK?N8YBpCV^E#5cL^%^6LPWifg4~QS&%?h%Vfe{EJfwVT*2mqk}AZ7pn

literal 0
HcmV?d00001

diff --git a/packages/yarnpkg-libzip/tests/fixtures/symlink.zip b/packages/yarnpkg-libzip/tests/fixtures/symlink.zip
new file mode 120000
index 000000000000..75a9ac7bd2a5
--- /dev/null
+++ b/packages/yarnpkg-libzip/tests/fixtures/symlink.zip
@@ -0,0 +1 @@
+symlink-source.zip
\ No newline at end of file