Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable Renovatebot for dependency management #2010

Open
2 tasks
ylemkimon opened this issue Oct 20, 2020 · 2 comments
Open
2 tasks

[Feature] Enable Renovatebot for dependency management #2010

ylemkimon opened this issue Oct 20, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@ylemkimon
Copy link
Contributor

ylemkimon commented Oct 20, 2020

  • I'd be willing to implement this feature
  • This feature can already be implemented through a plugin

Describe the user story
Renovate now supports Yarn 2 and its zero-install (renovatebot/renovate#7220).

It could also serve as an E2E test for Yarn 2 support of Renovate.

Describe the solution you'd like
Enable Renovatebot on the repo.

The config may be copied from https://github.com/yarnpkg/yarn/blob/master/renovate.json.

It's also possible to enable dedupe via postUpdateOptions: ["yarnDedupeHighest"] configuration.

Describe the drawbacks of your solution

  • Noise

Describe alternatives you've considered

  • Manual dependency management
@ylemkimon ylemkimon added the enhancement New feature or request label Oct 20, 2020
@arcanis
Copy link
Member

arcanis commented Oct 20, 2020

It would be interesting, especially in terms of dogfooding, but I'm personally a bit worried of the noise 🤔

In general we currently upgrade dependencies when we notice something we actually need (most frequently a feature), and so far it seems to work without requiring a lot of efforts from us. If we were to actively upgrade without precise reason, it would require much more triaging (and reviews are already taxing), and would increase the likelihood that a bug creeps past us.

@ylemkimon
Copy link
Contributor Author

@arcanis One way would be to enable dependencyDashboardApproval for all updates, i.e., Renovate will not create branches/PRs automatically but instead wait for manual approval by maintainers from within the Dependency Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants