Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] TypeScript resolution in latest dev build #2799

Closed
1 task
AaronDewes opened this issue Apr 24, 2021 · 5 comments · Fixed by #2889
Closed
1 task

[Bug] TypeScript resolution in latest dev build #2799

AaronDewes opened this issue Apr 24, 2021 · 5 comments · Fixed by #2889
Labels
bug Something isn't working upholded Real issues without formal reproduction

Comments

@AaronDewes
Copy link
Contributor

  • I'd be willing to implement a fix

Describe the bug

The latest dev version of TypeScript 4.3 doesn't work anymore, it fails to import anything. This was probably introduced through microsoft/TypeScript#43700.

To Reproduce

Create a project with typescript and any other package. Try to import the package in typescript.

Environment:

  • OS: Ubuntu 21.04
  • Node version 14
  • Yarn version 3.0.0-rc.2
@AaronDewes AaronDewes added the bug Something isn't working label Apr 24, 2021
@arcanis arcanis changed the title [Bug] [Bug] TypeScript resolution in latest dev build Apr 24, 2021
@arcanis
Copy link
Member

arcanis commented Apr 24, 2021

It seems this PR introduced conflicts. Starting from 3.0, when conflicts arise, rather than abort the install, we fallback on the regular TS package (so that you can at least switch to the node-modules linker until we can sort it out). Hence why resolutions don't work.

Note that the failed patch is probably in your install logs (at least the first time you install it).

@AaronDewes
Copy link
Contributor Author

Note that the failed patch is probably in your install logs (at least the first time you install it).

I don't have them anymore, but I can reinstall if you need them, but if you know what's wrong, you probably don't need it, do you?

@arcanis
Copy link
Member

arcanis commented Apr 24, 2021

Yep I think the info are enough, it was just to provide a bit of context. Thanks for the report 👍

@arcanis arcanis added the upholded Real issues without formal reproduction label Apr 24, 2021
@wdfinch
Copy link

wdfinch commented May 27, 2021

Noticing this on ts 4.3.2. Any updates here?

@SheepReaper
Copy link

It seems it's all 4.3.x
4.3.1-rc likewise, patch fails to apply but 4.2.4 is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upholded Real issues without formal reproduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants