[Bug] lodash.zip gets confused for a zip archive

[hlolli]

Problem:

on latest master with lodash.zip in the dep-tree

➤ YN0001: │ Error: While persisting /.yarn/cache/lodash.zip-npm-4.2.0-5299417ec8-41fd8dc1af.zip/node_modules/lodash.zip/ -> /node_modules/lodash.zip ENOTDIR: not a directory, scandir '/.yarn/cache/lodash.zip-npm-4.2.0-5299417ec8-41fd8dc1af.zip/node_modules/lodash.zip'
➤ YN0000: └ Completed in 1m 11s
➤ YN0000: Failed with errors in 1m 14s

Perhaps this check needs refinement?

berry/packages/yarnpkg-fslib/sources/ZipOpenFS.ts

Lines 34 to 35 in 70b63ef

	// The path either has to end in ".zip" or contain an archive subpath (".zip/...")
	if (path.length > nextCharIdx && path[nextCharIdx] !== ppath.sep)

extra info

> file .yarn/cache/lodash.zip-npm-4.2.0-5299417ec8-41fd8dc1af.zip/node_modules/lodash.zip
.yarn/cache/lodash.zip-npm-4.2.0-5299417ec8-41fd8dc1af.zip/node_modules/lodash.zip: cannot open `.yarn/cache/lodash.zip-npm-4.2.0-5299417ec8-41fd8dc1af.zip/node_modules/lodash.zip' (Not a directory)

> file .yarn/cache/lodash.zip-npm-4.2.0-5299417ec8-41fd8dc1af.zip
.yarn/cache/lodash.zip-npm-4.2.0-5299417ec8-41fd8dc1af.zip: Zip archive data, at least v2.0 to extract

 > file /node_modules/lodash.zip  
/node_modules/lodash.zip: cannot open `/node_modules/lodash.zip' (No such file or directory)

> file node_modules/lodash.zip/
node_modules/lodash.zip/: directory

> tree node_modules/lodash.zip/ 
node_modules/lodash.zip/

0 directories, 0 files

[GiladShoham]

This happen to us as well, and it's very critical for us.
We can't go back to the previous rc as then we got something like

Cannot find module '@yarnpkg/cli'
Require stack:
- my-app\node_modules\@yarnpkg\plugin-pack\lib\commands\pack.js
- my-app\node_modules\@yarnpkg\plugin-pack\lib\index.js
- my-app\node_modules\@teambit\yarn\node_modules\@yarnpkg\cli\node_modules\@yarnpkg\plugin-npm\lib\npmPublishUtils.js
- my-app\node_modules\@teambit\yarn\node_modules\@yarnpkg\cli\node_modules\@yarnpkg\plugin-npm\lib\index.js
- my-app\node_modules\@teambit\yarn\node_modules\@yarnpkg\cli\lib\tools\getPluginConfiguration.js
- my-app\node_modules\@teambit\yarn\node_modules\@yarnpkg\cli\lib\index.js
- my-app\node_modules\@teambit\yarn\dist\yarn.package-manager.js
- my-app\node_modules\@teambit\yarn\dist\yarn.main.runtime.js
- my-app\node_modules\@teambit\bit\dist\load-bit.js
- my-app\node_modules\@teambit\bit\dist\app.js
- my-app\node_modules\@teambit\bit\bin\bit

[ratson]

This can be reproduced by

$ yarn --version
3.0.0-rc.5.git.20210607.hash-017bb2f

$ yarn dlx npm-name-cli@3

[yarnbot]

Hi! 👋

This issue looks stale, and doesn't feature the reproducible label - which implies that you didn't provide a working reproduction using Sherlock. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it or you edit your first post to include a formal reproduction (you can use the playground for that).

Note that we require Sherlock reproductions for long-lived issues (rather than standalone git repositories or similar) because we're a small team. Sherlock gives us the ability to check which bugs are still affecting the master branch at any given point, and decreases the amount of code we need to run on our own machines (thus leading to faster bug resolutions). It helps us help you! 😃

If you absolutely cannot reproduce a bug on Sherlock (for example because it's a Windows-only issue), a maintainer will have to manually add the upholded label. Thanks for helping us triaging our repository! 🌟

[GiladShoham]

This is still not working with the latest version

[merceyz]

@GiladShoham Open a new issue with a reproduction please