Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: typescript-patch fails for tsconfig references that are resolved to workspace:. by PnP #3231

Closed
1 task done
sushruth opened this issue Aug 5, 2021 · 0 comments · Fixed by #3297
Closed
1 task done
Labels
bug Something isn't working

Comments

@sushruth
Copy link

sushruth commented Aug 5, 2021

Self-service

Describe the bug

TSServer from typescript-patch seems to handle reference paths wrongly in pnp environment.

I have suggested a fix currently (maybe there is a better solution than that) at the original TS PR here - microsoft/TypeScript#35206 (comment)

I have tested that fix locally by unplugging typescript and then editing the files to see if it works. It does seem to work so far.

To reproduce

https://github.com/sushruth/berry-issue - this repo shows a minimal repro for this. I found it really difficult to write a sherlock repro code for tsserver usage. I hope this repo will be sufficient.

Environment


  System:
    OS: Windows 10 10.0.22000
    CPU: (48) x64 AMD Ryzen Threadripper 3960X 24-Core Processor
  Binaries:
    Node: 14.16.0 - ~\AppData\Local\Temp\xfs-cd3255e2\node.CMD
    Yarn: 3.0.0 - ~\AppData\Local\Temp\xfs-cd3255e2\yarn.CMD
    npm: 6.14.11 - ~\scoop\apps\nvm\current\nodejs\nodejs\npm.CMD


Additional context

No response

@sushruth sushruth added the bug Something isn't working label Aug 5, 2021
@sushruth sushruth changed the title [Bug?]: typescript-patch fails for tsconfig references that are within the directory structure of workspace:. [Bug?]: typescript-patch fails for tsconfig references that are within the directory structure of workspace:. Aug 5, 2021
@sushruth sushruth changed the title [Bug?]: typescript-patch fails for tsconfig references that are within the directory structure of workspace:. [Bug?]: typescript-patch fails for tsconfig references that are deep within the directory structure of workspace:. Aug 5, 2021
@sushruth sushruth changed the title [Bug?]: typescript-patch fails for tsconfig references that are deep within the directory structure of workspace:. [Bug?]: typescript-patch fails for tsconfig references that are resolved to workspace:. by PnP Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant