Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OIDC flow #4

Merged
merged 22 commits into from
Dec 7, 2021
Merged

feat: OIDC flow #4

merged 22 commits into from
Dec 7, 2021

Conversation

wsalles
Copy link
Contributor

@wsalles wsalles commented Nov 25, 2021 •
edited by jira bot
Loading

closes PLT-24

@wsalles wsalles self-assigned this Nov 25, 2021
@wsalles wsalles marked this pull request as ready for review November 26, 2021 12:19
@wsalles wsalles marked this pull request as draft November 26, 2021 12:46
@portellaa
Copy link
Member

Could you please change the title of the PR?

@wsalles wsalles changed the title feat: initial project [PLT-24] feat: OIDC flow Nov 26, 2021
portellaa
portellaa requested changes Nov 26, 2021
View reviewed changes
Copy link
Member

@portellaa portellaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still think this misses the oidc flow, i mean it's somehow in here, but the way and places it's done, it's messy.

you are putting logic "random methods" like the helpers for the server, please improve that part.

i don't think we need middlewares for now and also don't think that our go-core server supports it, but that is something we could improve in our go-core server

internal/server/server.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/server/server_helper.go Outdated Show resolved Hide resolved
internal/server/server_helper.go Outdated Show resolved Hide resolved
internal/server/server_helper.go Outdated Show resolved Hide resolved
renatoaguimaraes
renatoaguimaraes suggested changes Nov 29, 2021
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
internal/clients/oidc.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/services/rest_service.go Outdated Show resolved Hide resolved
@wsalles wsalles marked this pull request as ready for review November 30, 2021 19:17
renatoaguimaraes
renatoaguimaraes suggested changes Nov 30, 2021
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/services/rest_service.go Outdated Show resolved Hide resolved
portellaa
portellaa reviewed Dec 1, 2021
View reviewed changes
internal/clients/oidc.go Outdated Show resolved Hide resolved
internal/clients/oidc_configuration.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/services/rest_service.go Outdated Show resolved Hide resolved
renatoaguimaraes
renatoaguimaraes suggested changes Dec 6, 2021
View reviewed changes
internal/clients/oidc.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Show resolved Hide resolved
renatoaguimaraes
renatoaguimaraes reviewed Dec 6, 2021
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
internal/clients/oidc.go Outdated Show resolved Hide resolved
portellaa
portellaa reviewed Dec 6, 2021
View reviewed changes
internal/clients/oidc.go Outdated Show resolved Hide resolved
internal/clients/oidc.go Show resolved Hide resolved
internal/clients/oidc.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/session.go Outdated Show resolved Hide resolved
internal/services/session.go Outdated Show resolved Hide resolved
internal/services/session_configuration.go Outdated Show resolved Hide resolved
internal/clients/oidc.go Outdated Show resolved Hide resolved
renatoaguimaraes
renatoaguimaraes suggested changes Dec 7, 2021
View reviewed changes
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/models/session.go Outdated Show resolved Hide resolved
renatoaguimaraes
renatoaguimaraes suggested changes Dec 7, 2021
View reviewed changes
internal/services/oidc.go Outdated Show resolved Hide resolved
portellaa
portellaa reviewed Dec 7, 2021
View reviewed changes
internal/clients/oidc_configuration.go Outdated Show resolved Hide resolved
internal/clients/oidc.go Outdated Show resolved Hide resolved
internal/clients/oidc.go Outdated Show resolved Hide resolved
internal/handlers/helpers.go Outdated Show resolved Hide resolved
internal/models/session.go Show resolved Hide resolved
internal/models/session.go Outdated Show resolved Hide resolved
internal/models/session.go Outdated Show resolved Hide resolved
internal/models/session.go Outdated Show resolved Hide resolved
internal/models/session.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
portellaa
portellaa reviewed Dec 7, 2021
View reviewed changes
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
internal/services/oidc.go Outdated Show resolved Hide resolved
@wsalles wsalles requested a review from portellaa December 7, 2021 19:53
@wsalles wsalles merged commit 8c5647f into master Dec 7, 2021
@wsalles wsalles deleted the feat/PLT-24 branch December 7, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portellaa portellaa portellaa approved these changes

@renatoaguimaraes renatoaguimaraes Awaiting requested review from renatoaguimaraes

Assignees

@wsalles wsalles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsalles @portellaa @renatoaguimaraes