Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: metrics package #7

Merged
merged 5 commits into from
Nov 5, 2021
Merged

feat: metrics package #7

merged 5 commits into from
Nov 5, 2021

Conversation

wsalles
Copy link
Contributor

@wsalles wsalles commented Sep 23, 2021

closes #6

@wsalles wsalles self-assigned this Sep 23, 2021
@portellaa
Copy link
Member

please fix the title 😂 it's matrics

@portellaa
Copy link
Member

@wsalles

please fix the title of the PR and in the commit, you have matrics instead of metrics
please remove (#6) from the commit title, that's not needed

@wsalles wsalles changed the title feat: matrics package feat: metrics package Sep 23, 2021
portellaa
portellaa reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@portellaa portellaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just a comment.

could we create some documentation on how to use metrics?

pkg/common/types.go Outdated Show resolved Hide resolved
victoriavilasb
victoriavilasb reviewed Sep 27, 2021
View reviewed changes
pkg/common/types.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
portellaa
portellaa reviewed Oct 11, 2021
View reviewed changes
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
renatoaguimaraes and others added 2 commits October 22, 2021 11:50
@renatoaguimaraes @wsalles
feat(k8s): k8s helper to set owner reference (#8)
5604bbf 
Signed-off-by: Renato Guimaraes <[email protected]>

feat: metrics package

feat: metrics package
@wsalles
feat(pkg): metrics package
7534bb1
@wsalles wsalles merged commit 93959fc into master Nov 5, 2021
@wsalles wsalles deleted the feat/matrics-pkg branch November 5, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoriavilasb victoriavilasb victoriavilasb left review comments

@portellaa portellaa portellaa approved these changes

@renatoaguimaraes renatoaguimaraes Awaiting requested review from renatoaguimaraes

Assignees

@wsalles wsalles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: metrics package
4 participants
@wsalles @portellaa @victoriavilasb @renatoaguimaraes