Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable collections #1008

Closed
BinaryIgor opened this issue Jan 15, 2019 · 6 comments
Closed

Mutable collections #1008

BinaryIgor opened this issue Jan 15, 2019 · 6 comments

Comments

@BinaryIgor
Copy link
Contributor

We should create MutableCollectionEnvelope. Objects immutability is our core principle, but I think that mutability of collections is something different and it is often the case that we need them (#898).

@0crat
Copy link
Collaborator

0crat commented Jan 15, 2019

@llorllale/z please, pay attention to this issue

@wladyan
Copy link

wladyan commented Jan 15, 2019

@Iprogrammerr I think envelopes must be orthogonal to immutability principle (#947).

@BinaryIgor
Copy link
Contributor Author

@wladyan I agree. I propose to refactor CollectionEnvelope so that it does not care about immutability as described in #947. We then could add ImmutableCollection decorator that will work in the same manner as CollectionEnvelope is right now. I am willing to do that. @llorllale WDYT?

@llorllale
Copy link
Contributor

@Iprogrammerr this is a duplicate of #947

@0crat
Copy link
Collaborator

0crat commented Jan 16, 2019

Job gh:yegor256/cactoos#1008 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Jan 16, 2019

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants