Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constants should be on the right side of comparison #716

Open
mkordas opened this issue Feb 16, 2016 · 6 comments
Open

Constants should be on the right side of comparison #716

mkordas opened this issue Feb 16, 2016 · 6 comments
Labels
bug help wanted postponed

Comments

@mkordas
Copy link
Contributor

mkordas commented Feb 16, 2016

When comparing variables with constants there are two possible approaches:
if (null == variable)
or
if (variable == null)

Let's enforce the second one, so that constant value (string literal, null or number) is on the right side of comparison.
@krzyk
Copy link
Collaborator

krzyk commented Feb 16, 2016

@davvd valid bug

@davvd
Copy link

davvd commented Feb 24, 2016

@davvd valid bug

@krzyk tag bug added to this issue

@krzyk
Copy link
Collaborator

krzyk commented Mar 6, 2016

@davvd this is postponed

@davvd
Copy link

davvd commented Mar 7, 2016

@davvd this is postponed

@krzyk thanks, I added "postponed" label

@davvd
Copy link

davvd commented Mar 7, 2016

@davvd this is postponed

@krzyk right, I will find someone else, no problem

@davvd davvd added the postponed label Mar 7, 2016
@davvd
Copy link

davvd commented Mar 10, 2016

@mkordas thanks for tis bug, I topped your account for 15 mins, transaction 56e13577e401064b670000ca

@LaithAlebrahim LaithAlebrahim mentioned this issue Mar 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted postponed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@krzyk @yegor256 @mkordas @davvd