-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing tail is sometimes redundant, need a way to turn it off #881
Comments
@Suseika I don't think that it is a good idea, we introduced tail because it is easier to look at those and not click on a link and scroll down a MB of text. |
What do you mean by decide? If I want the tail, I say |
@Suseika sorry I saw only the |
@krzyk Yeah, the |
@Suseika I don't really like this |
@yegor256 Logs are not that long, but sometimes you expect many consecutive builds to fail, so a length of a log multiplied by a number of attempts becomes quite significant. I had a problem when I was trying out rultor in one of my repositories. I expected builds to fail (and they did) because it was the first time I tried to configure rultor to release a new version: gvlasov/rocollections#4. Basically, in an "it works for me but doesn't work for rultor" situation when I expect a lot of failed builds I'd like to have that feature. |
@Suseika @krzyk how about another idea. When rultor posts a new tail it goes up through all previous messages and deletes all tails there. Thus, we will always have the last tail only. What do you think? |
@yegor256 That would be great for me, but I'm not sure if others using rultor would need the old tails or not. |
@yegor256 I think the best would be to put it in spoiler tag (click to show) but github doesn't seem to have one. I wouldn't go with removing tails, unless it is the same as the last one. Sometimes it is useful to find when certain failures started appearing. |
@krzyk yeah... indeed, deleting history is a rather bad practice... let's keep this ticket on hold and see what other users may think about it |
@alex-palevsky let's postpone it |
@suseika we will find someone to do this task, soon |
@suseika I added milestone |
@suseika thanks for reporting! I topped your account for 15 mins, transaction AP-67T38338FX960393B |
@yegor256 sure, thanks, I added "postponed" tag to it |
@yegor256 I will try to find someone else |
#807 introduces a great feature of showing the tail of build log if something fails. But sometimes the tails of failed build attemts flood the conversation in an issue, if build is failed repeatedly.
Can we have a feature to turn showing tail off, leaving just the "Oops, I failed!" message with the link to the full log? For example,
quiet
ornotail
command in a message to rultor, or a directive in.rultor.yml
that disables showing tails.The text was updated successfully, but these errors were encountered: