LifecycleTest.java:81-83: Implement MkScenario and MkStep. Rewrite...

[davvd]

Puzzle 351-ebb2c3b5 in src/test/java/com/thindeck/life/LifecycleTest.java:81-83 has to be resolved: Implement MkScenario and MkStep. Rewrite the test after that using mocks from com.thindeck.api.mock package instead of mockito.

[davvd]

@soliveri this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here

[davvd]

@soliveri The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

[davvd]

@soliveri it takes too long. Usually, we expect any task to be finished in less than a week. I'll assign someone else. Please stop working with it right now. See our no obligations principle

[davvd]

@php-coder the task is for you now, follow these guidelines. Don't hesitate to ask any technical questions right here

Budget here is 30 mins (keep this principle in mind)

[php-coder]

When I run static analysis I've got the following messages:

$ mvn -Pqulice qulice:check 2>/dev/null | egrep 'MkStep|MkScenario|LifecycleTest'
[ERROR] /src/main/java/com/thindeck/api/mock/MkScenario.java[2]: Line does not match expected header line of ' * BSD License'. (HeaderCheck)
[ERROR] /src/main/java/com/thindeck/api/mock/MkStep.java[2]: Line does not match expected header line of ' * BSD License'. (HeaderCheck)
[ERROR] /src/test/java/com/thindeck/life/LifecycleTest.java[2]: Line does not match expected header line of ' * BSD License'. (HeaderCheck)
[ERROR] /src/test/java/com/thindeck/life/LifecycleTest.java[38]: Wrong order for 'org.hamcrest.Matchers' import. (ImportOrderCheck)

Question No1: What's wrong with header? I see that error for a lot of files. How I can fix it? Where I can read more about this check?
Question No2: Where I can find rules for ordering imports? I don't understand the logic behind this check..
Question No3: Why we need to add @Version $Id$ javadoc? For what it needed? Who and when will substitute that $Id$?

[php-coder]

I've created pull request #427 with my changes. Also see my comment in request's description.

[yegor256]

1. did you fix the header already? I think you did, since the pull request is there
2. imports should be ordered alphabetically. no static imports. no asterisks.
3. it's an inherited rudimentary thing, from SVN. just put it there. in Git it's useless, but our rules are the same for SVN and Git

[php-coder]

did you fix the header already? I think you did, since the pull request is there

No, I didn't. May it somehow related to OS (I suspect that it's issue with newlines) where tests were run. I run them under Mac OS X.

imports should be ordered alphabetically. no static imports. no asterisks.

Ok, thanks. I've fixed it now and pushed to my branch.

BTW, my pull request fails but I believe that it's not by fault because I didn't touch NginxTest.canUpdateNginxHttpConfig..

[php-coder]

One more question: "Puzzle 351-ebb2c3b5" What is it? 351 it's a ticket number? ebb2c3b5 it's a sha1 of related commit? Am I right?

[yegor256]

It's an internal number we use to identify every puzzle in a unique way

[yegor256]

Looks like your pull request is almost good to go, just a few minor corrections. I've made a comment right there, in #427

[php-coder]

@davvd Please, close the task.

[davvd]

We're done here, thanks all

[davvd]

@php-coder thank you, added 30 mins to your acc, payment num is AP-9Y091764KS910605M