Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks are not removed from Vec in file upload example #2035

Closed
allsey87 opened this issue Sep 6, 2021 · 1 comment · Fixed by #2055
Closed

Tasks are not removed from Vec in file upload example #2035

allsey87 opened this issue Sep 6, 2021 · 1 comment · Fixed by #2055
Labels
A-examples Area: The examples bug

Comments

@allsey87
Copy link

allsey87 commented Sep 6, 2021

Problem
In the file upload example, tasks are never removed from tasks: Vec<ReaderTask>.

Steps To Reproduce
Study the code in the example

Expected behavior
The task should be removed once Msg::Loaded arrives at the component.

Environment:
Yew version: v0.18
@allsey87 allsey87 added the bug label Sep 6, 2021
@siku2 siku2 added the A-examples Area: The examples label Sep 6, 2021
This was referenced Sep 13, 2021
Closed
Merged
Merged
@mc1098
Copy link
Contributor

mc1098 commented Sep 14, 2021

Thank you for the issue! ❤️

#2054 fixes the example for v0.18 :)
The same issue still exists in master so #2055 will fix that and close this issue 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-examples Area: The examples bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix not removing readers in file upload example mc1098/yew
3 participants
@allsey87 @siku2 @mc1098