Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket messages that fail "format" check are ignored #859

Closed
jstarry opened this issue Jan 9, 2020 · 1 comment
Closed

Websocket messages that fail "format" check are ignored #859

jstarry opened this issue Jan 9, 2020 · 1 comment
Labels
feature-request A feature request

Comments

@jstarry
Copy link
Member

jstarry commented Jan 9, 2020

Is your feature request related to a problem? Please describe.
The websocket service drops messages that cannot be "formatted" correctly and does not log or return any error to the user when this happens.

Describe the solution you'd like

  1. Either add logging (or panic) on debug builds when this happens.
  2. Allow users to receive callbacks for message format errors
@jstarry jstarry added the feature-request A feature request label Jan 9, 2020
@jstarry jstarry changed the title Websocket messages that do not deserialize are ignored Websocket messages that fail "format" check are ignored Jan 9, 2020
@mc1098
Copy link
Contributor

mc1098 commented Aug 2, 2021

#1842 removed the WebSocketService so I think this can be closed.

@siku2 siku2 closed this as completed Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jstarry @siku2 @mc1098