Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed usage of Python2 and Python3. #8

Open
aakashsur opened this issue Mar 5, 2019 · 3 comments
Open

Mixed usage of Python2 and Python3. #8

aakashsur opened this issue Mar 5, 2019 · 3 comments

Comments

@aakashsur
Copy link

It looks like s4_bin.sh uses python (which maps to python2 usually) instead of python3. I'm assuming they can all be run using python3 so I guess I would either change the python calls in the bash script or update the documentation to reflect the Python 2 usage before that step.

@yezhengSTAT
Copy link
Owner

All the python scripts in mHi-C are tested using python3.

@aakashsur
Copy link
Author

Okay, then it looks like changing these lines should fix the problem:

mHiC/s4_bin.sh

Lines 166 to 173 in 0d34bee

if [ "$normMethod" != "None" ] && [ "$normMethod" != "NONE" ] && [ "$normMethod" != "none" ] && [ "$normMethod" != "" ]; then
if [ "$normMethod" == "ICE" ] || [ "$normMethod" == "ice" ]; then
# ICE normalization with filtering low mappability regions
python $bin/ICE-with-sparseMatrix.py $validI.binPairCount.uni.minCount$minCount $mappFile l1 $validI.binPairCount.uni.ICEnorm $minMap $maxIter
else
python $bin/KR_norm_mHiC.py -r $resolution -l $chromSizeFile -c "whole" -tr $sparsePerc -f $validI.binPairCount.uni.minCount$minCount -o $dir
fi

@yezhengSTAT
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants