Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldMaximizeOnClick doesn't work #74

Closed
Ruslan27032000 opened this issue May 19, 2022 · 2 comments
Closed

shouldMaximizeOnClick doesn't work #74

Ruslan27032000 opened this issue May 19, 2022 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Ruslan27032000
Copy link

I have Carousel with shouldMinimizeOnClick and shouldMaximizeOnClick. In mobile version maximize working great, but if I click on toggle device toolbar and click on image it doesn't work.

Steps to reproduce the behavior:

  1. Go to https://yifaneye.github.io/react-gallery-carousel/
  2. Open console and click on "Toggle device toolbar". Choose Some phone(for example IPhone XR)
  3. Scroll down to carousel with shouldMaximizeOnClick
  4. See error

image
image

@yifaneye
Copy link
Owner

Hi @Ruslan27032000 Thanks for raising this issue up! I will investigate!

@yifaneye yifaneye self-assigned this May 24, 2022
@yifaneye yifaneye added bug Something isn't working good first issue Good for newcomers labels May 24, 2022
@yifaneye yifaneye mentioned this issue Oct 15, 2022
@yifaneye
Copy link
Owner

Hi @Ruslan27032000 !

This issue is because the touch event is recognized additionally as a mouse event on simulated mobile devices (e.g. Toggle Device Toolbar on Chrome).

It is now fixed in v0.3.0. See the gif below. 😁
issue-74-fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants