Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker for tests #3

Open
machour opened this issue Jan 17, 2019 · 12 comments
Open

Docker for tests #3

machour opened this issue Jan 17, 2019 · 12 comments

Comments

@machour
Copy link
Member

machour commented Jan 17, 2019

I'd like to discuss the possibility of adding Docker setups in each repositories to help developers running tests.

This wouldn't be a requirement to run tests, and it won't be involved during the Travis builds.

It would allow us to run docker-compose up in the tests directory and immediately having a working environment to fiddle with the extension.

@samdark
Copy link
Member

samdark commented Jan 17, 2019

I'm not using Docker much for Yii development but if it helps I'm not against it. @schmunk42 what do you think?

@schmunk42
Copy link
Contributor

I support the idea 100% \o/

@machour: just @ me at will or reach out on Slack or via E-mail.
With which repo do you wanna start?

@kids-return
Copy link

I support, first build a basic image, and then define it separately according to different extensions.
But I think this can be done later, it is most important to make the whole framework work properly, so that you can find out where the framework needs to be adjusted and fixed earlier.

@schmunk42
Copy link
Contributor

We have that already ;) https://github.com/yiisoft/yii-docker

Including tests with phpunit tests/framework/ --exclude db
https://travis-ci.com/yiisoft/yii-docker

@samdark
Copy link
Member

samdark commented Jan 17, 2019

It isn't about travis. It's about running stuff locally.

@schmunk42
Copy link
Contributor

I support, first build a basic image, and then define it separately according to different extensions.

I actually referred to this, what I wanted to say is: There are Docker images for Yii 3.x

@machour
Copy link
Member Author

machour commented Jan 18, 2019

@kids-return This is for fixing tests. I was about to install sphinx and elasticsearch on my laptop to try and fix tests when I thought of this.

@samdark
Copy link
Member

samdark commented Aug 9, 2019

Experienced all kinds of breakage with travis recently so now I'm all for it :)

@samdark samdark transferred this issue from yiisoft/yii-core Sep 7, 2019
@schmunk42
Copy link
Contributor

So, there are 7.4 images now. But which tests can/should be run since there's no more yii-core?

@samdark
Copy link
Member

samdark commented Dec 17, 2019

Tests for each individual package: https://www.yiiframework.com/status/3.0. But that's not a priority for now. Travis is OK except it being a bit slow. We're considering GitHub actions though.

@schmunk42
Copy link
Contributor

What takes a lot of time (and space) is a composer install (with dev-packages) for each package, but I think it is the cleanest way to do it.

I'd recommend to run tests which do not need external services such as DBs or caches, since we already have found issues with PHP versions or operating systems.

We can start with a smaller set and/or use branches or triggers to run more if required.

@samdark
Copy link
Member

samdark commented Dec 17, 2019

I think it's better to focus on something else... Travis currently isn't problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants