-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker for tests #3
Comments
I'm not using Docker much for Yii development but if it helps I'm not against it. @schmunk42 what do you think? |
I support the idea 100% \o/ @machour: just @ me at will or reach out on Slack or via E-mail. |
I support, first build a basic image, and then define it separately according to different extensions. |
We have that already ;) https://github.com/yiisoft/yii-docker Including tests with |
It isn't about travis. It's about running stuff locally. |
I actually referred to this, what I wanted to say is: There are Docker images for Yii 3.x |
@kids-return This is for fixing tests. I was about to install sphinx and elasticsearch on my laptop to try and fix tests when I thought of this. |
Experienced all kinds of breakage with travis recently so now I'm all for it :) |
So, there are 7.4 images now. But which tests can/should be run since there's no more |
Tests for each individual package: https://www.yiiframework.com/status/3.0. But that's not a priority for now. Travis is OK except it being a bit slow. We're considering GitHub actions though. |
What takes a lot of time (and space) is a I'd recommend to run tests which do not need external services such as DBs or caches, since we already have found issues with PHP versions or operating systems. We can start with a smaller set and/or use branches or triggers to run more if required. |
I think it's better to focus on something else... Travis currently isn't problematic. |
I'd like to discuss the possibility of adding Docker setups in each repositories to help developers running tests.
This wouldn't be a requirement to run tests, and it won't be involved during the Travis builds.
It would allow us to run
docker-compose up
in the tests directory and immediately having a working environment to fiddle with the extension.The text was updated successfully, but these errors were encountered: