feat(improvement): restJoystick now accepts an object

[htshah]

Currently the restJoystick option only accepts boolean values. This means that I can't specify which axis should be re-centered on rest state. For example, in my use case I only want the Y-axis to be reset on rest state while the X-axis should remain in the same position.

This improvement will add this capability to the library. This is how we'll be able to use restJoystick option:

var joystick = nipple.create({
    restJoystick: true,
    // This is converted to {x: true, y: true}

    // OR
    restJoystick: false,
    // This is converted to {x: false, y: false}

    // OR
    restJoystick: {x: false},
    // This is converted to {x: false, y: true}

    // OR
    restJoystick: {x: false, y: true},
});

Although a small improvement, it'll be useful of many of us.

[yoannmoinet]

Some formatting issues and I don't understand why you had to duplicate the transformation logic.

Although, I wouldn't keep that logic randomly placed in the code, I'd just do it where we actually use the option.

[yoannmoinet]

Suggested change

	if(typeof restJoystick === 'boolean'){
	this.options.restJoystick = {
	x: restJoystick,
	y: restJoystick,
	};
	}else if(typeof restJoystick === 'object'){
	this.options.restJoystick = u.safeExtend({x:true,y:true},restJoystick);
	}
	if (typeof restJoystick === 'boolean'){
	this.options.restJoystick = {
	x: restJoystick,
	y: restJoystick,
	};
	} else if (typeof restJoystick === 'object') {
	this.options.restJoystick = u.safeExtend({x:true, y:true}, restJoystick);
	}

[htshah]

fixed.. (removed this duplicated logic)

[yoannmoinet]

Suggested change

	const restJoystick = this.options.restJoystick;
	if(typeof restJoystick === 'boolean'){
	this.options.restJoystick = {
	x: restJoystick,
	y: restJoystick,
	};
	}else if(typeof restJoystick === 'object'){
	this.options.restJoystick = u.safeExtend({x:true,y:true},restJoystick);
	}
	const restJoystick = this.options.restJoystick;
	if (typeof restJoystick === 'boolean') {
	this.options.restJoystick = {
	x: restJoystick,
	y: restJoystick,
	};
	} else if (typeof restJoystick === 'object') {
	this.options.restJoystick = u.safeExtend({x:true, y:true}, restJoystick);
	}

[htshah]

fixed.. (removed this duplicated logic)

[yoannmoinet]

I think it's best to have this logic just once where we do actually use it.
You can remove the other logics that you duplicated.

Suggested change

	self.setPosition(cb, {
	x: self.options.restJoystick.x ?0 :self.instance.frontPosition.x,
	y: self.options.restJoystick.y ?0 :self.instance.frontPosition.y
	});
	if (self.options.restJoystick) {
	const rest = self.options.restJoystick;
	const newPosition = {};
	newPosition.x = rest === true || rest.x ? 0 : self.instance.frontPosition.x;
	newPosition.y = rest === true || rest.y ? 0 : self.instance.frontPosition.y;
	self.setPosition(cb, newPosition);
	}

[htshah]

refactored it as you request..

[yoannmoinet]

Awesome, LGTM.
Sorry for the delay, I'll make a release later today.