-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joystick does not "end" and lock #72
Comments
I'm closing this as #74 should have fixed this. |
@yoannmoinet Arg, I'm afraid I'm still seeing this happen on I'm going to try to slim down my code into smaller reproducible example, but in the meanwhile, I'm curious if anyone else has still been seeing this happen? |
Okay, I've been able to reduce this fairly regularly in the demo linked from the README, although not as frequently as in my own app (where it happens consistently after ~5 seconds of normal use). On the demo screen, I'm able to most easily trigger it when using multitouch (basically swiping the demo area frantically with both thumbs to spawn and despawn lots of joysticks in a short time). |
Let me know if me continuing to rant here isn't helpful (I'm hoping to nail down a consistent repro + fix myself), but if anyone else is jamming on this, I've managed to reproduce it in the online demo on desktop with a mouse, so it appears to not be exclusively related to touch handling and touch events. |
@lazerwalker don't worry about your rant, it's helpful. I don't have much time lately to really investigate on the issue, but I'm very glad someone is trying. Cheers, and again, thank you! |
I spent a bunch of time diving into this, but came up blank. @robertlong's suggested fix in #31 (comment) appears to work for me (just passing in In my case, it appeared that the high-level NippleJS DOM element wasn't even getting |
I'm still not able to reproduce the issue. Feel free to re-open once you have more details and some clear repro steps. |
Sometime the "end" event is not triggered and the nipple does not disapear. I have to reload the page.
However, the "remove" event is always triggered.
Is there a way to force the nipple destruction in the "remove" event ? I tried "nipple.destroy()" without succes.
Here my source :
` var joystick = new nipplejs.create({
zone : document.getElementById('mjpegplayercontainer'),
color : 'blue',
size : 200,
//mode : 'semi',
//catchDistance : 100
});
The text was updated successfully, but these errors were encountered: