Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive Carthage dependencies #266

Open
LinusU opened this issue Mar 13, 2018 · 5 comments
Open

Recursive Carthage dependencies #266

LinusU opened this issue Mar 13, 2018 · 5 comments

Comments

@LinusU
Copy link
Contributor

LinusU commented Mar 13, 2018

I'm not 100% if this is within the scope of this project, but currently, when adding Carthage dependencies you also have to manually add any Carthage dependencies that they may in their turn depend on.

E.g. I might have an iOS application that depends on BioPass. I add github "LinusU/BioPass" ~> 1.1.1 to my Cartfile, and - carthage: BioPass to the dependencies in project.yml.

Now, BioPass in turns depends on PromiseKit, and Carthage will correctly pick this up and install both BioPass and PromiseKit. However, trying to run the built app will crash with: Library not loaded: @rpath/PromiseKit.framework/PromiseKit.

The current fix is to add - carthage: PromiseKit to the list in project.yml, and then all is well. However, I think it would be excellent if this could be done automatically, as Carthage does.

@toshi0383
Copy link
Collaborator

toshi0383 commented Mar 26, 2018

I thought XcodeGen shouldn't know about Cartfile.resolved, but it already knows about internal behavior like where carthage frameworks are built (Carthage/Build/$platform) and so on, so I guess this can be within the scope of XcodeGen. 🤔

Thoughts, @yonaskolb ?

@toshi0383
Copy link
Collaborator

Oh I realized that it's impossible because we cannot determine which frameworks to go into which target.🙄

@yonaskolb
Copy link
Owner

Yeah, not sure if we can easily do this

@GRiMe2D
Copy link

GRiMe2D commented May 28, 2020

Hello everyone!

Wasn't this pr #506 meant to resolve this issue? I'm currently trying to make it work but unfortunately Xcodegen doesn't automatically link.

@yonaskolb
Copy link
Owner

@GRiMe2D that PR was more for single dependencies that come with multiple frameworks, not transitive Carthage dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants