Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to embed Carthage frameworks without using copy-frameworks #359

Closed
brentleyjones opened this issue Jul 24, 2018 · 4 comments
Closed
Assignees

Comments

@brentleyjones
Copy link
Collaborator

brentleyjones commented Jul 24, 2018

On our project we have many test targets, and all of them depend on Carthage versions of Quick and Nimble. When we build this with parallel builds enabled a Carthage bug can be hit where two instances of copy-frameworks try to strip the same dSYM (Carthage/Carthage#2531). Since test targets don't really need to strip anything at all, it would be good to be able to specify on a target that we want to embed the Carthage frameworks instead of using copy-frameworks. It can default properly for test targets.

I will add a directlyEmbedCarthageDependencies to Target. Right now it would be true for .macOS platform, and I'll extend it to be true for test targets as well.

@brentleyjones brentleyjones self-assigned this Jul 24, 2018
@yonaskolb
Copy link
Owner

In my opinion this is a big in Carthage and should be fixed there. Is there any other reason you would want to turn this on?

@brentleyjones
Copy link
Collaborator Author

They just said it's a bug on our side. They are correct. Only iOS apps need to use that script, since no other targets need to strip the simulator slice. I have a PR incoming.

@brentleyjones
Copy link
Collaborator Author

Is there any other reason you would want to turn this on?

Mainly the option would be to turn it off, since we will default it to on for basically everything but the application.

@brentleyjones
Copy link
Collaborator Author

I guess on macOS you might want to strip the frameworks as well? Another case for adjusting the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants