-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper for carthage related frameworks #488
Comments
Awesome ! +1 for it becoming the default as most of the time you want to embed those. |
@yonaskolb happy to take a stab at implementing this as it seems like it would be a useful feature. |
After a quick glance there are a few different ways we can do this but it's mainly down to 2 choices:
Option 1 is a lot simpler and cleaner but feels a bit wrong for some reason. We will have to reach into the Carthage build folder to get the Option 2 will likely require changing logic related to carthage dependencies in a few different places. Keen to hear your thoughts on this. |
That would be great if you want to work on this @rpassis! |
This was added |
This would add an option to a carthage dependency that would copy all of its related frameworks as well.
This is for some carthage dependencies that actually have multiple frameworks you need to embed.
For example https://github.com/DaveWoodCom/XCGLogger requires that you embed both
XCGLogger
andObjcExceptionBridging
.XcodeGen could read the file in
Carthage/Build/.XCGLogger.version
to extract all the required build artifacts:This functionality could live behind a flag. Something like the following:
old:
new:
This behaviour could even be made the default but it would be a breaking change as sometimes you don't want to embed all of a dependencies frameworks
The text was updated successfully, but these errors were encountered: