-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support xcconfig #59
Comments
Hi @toshi0383, thanks for the suggestions! Yeah, you're right there's no way to specify a project's xcconfig file. Setting In terms of adding them to the project, I'd like to keep defining configurations and applying xcconfig files in seperate dictionaries. While it's not hugely documented at the moment the About the renaming, I agree maybe Feel free to get a PR up and going! 👍 |
Yeah maybe my spec is wrong. Would you mind sharing a working example spec for me?
Could you share outline spec? I don't see the whole picture yet, since I haven't used
Alright. I will fix this maybe in different PR.
Great! I will take
Sure, I am going to at first deprecate it and add warning message when people use the old values. |
So this is what I came up with. What do you think? name: MyProject
configurations:
Debug: debug
OTA: release
Release: release
configurationFiles:
Debug: configs/MyApp-Debug.xcconfig
OTA: configs/MyApp-OTA.xcconfig
Release: configs/MyApp-Release.xcconfig
targets:
MyApp:
type: application
platform: iOS
sources: Sources/MyApp
settings:
PRODUCT_BUNDLE_IDENTIFIER: jp.toshi0383.hello
configurationFiles:
Debug: configs/MyApp-Debug.xcconfig
OTA: configs/MyApp-OTA.xcconfig
Release: configs/MyApp-Release.xcconfig |
🚀 |
Motivation
Auto apply xcconfig configurations like this.
Current Problems
I notice documentations do mention about xcconfig but looks like it's not working as expected.
configFiles
does not affect anything. (Bug? or maybe my spec is wrong)Proposal
So this is my proposal.
baseConfiguration
for PBXProjconfigFiles
withbaseConfigurations
for consistency.configs
toconfigurations
since it looks likexcconfig
and is misleading.If you guys feel happy with this outline, I can start working on a PR. 💪
The text was updated successfully, but these errors were encountered: