-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make using stable or nightly configurable #22
Comments
I'd argue we could probably default to stable, and perhaps add an extra check for |
Sounds good to me! If we include crossgen --channel beta
crossgen --channel nightly
# vs
crossgen --beta
crossgen --nightly |
@danreeves yeah, I think so! It'd also be cool if we could write them as shorthands too: $ crossgen -c stable @danreeves it's probably also worth considering how much of channels we're testing. E.g. for a default configuration we'd probably want something like:
There's probably a balance to be found in how many tests we run. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
pls no @Stale bot 🙏 |
Feature Request
Summary
Add a flag which toggles between generating stable or nightly config.
Motivation
Currently crossgen only supports generating config to test on nightly. If someone want's to test on stable instead they have to manually change all the places which say nightly.
Expected Behavior
crossgen
: current default is to generate nightly configcrossgen --stable
: create config for stableThere's currently only a handful of places where a switch would be needed. In
.travis.yml
and in https://github.com/yoshuawuyts/crossgen/blob/master/templates/lib/script.sh#L22Drawbacks
Not sure how it might be implemented: some sort of templating or just bash conditionals?
Rationale and alternatives
The only other alternative is manual changes after running crossgen
Unresolved Questions
Should stable or nightly be the default. I'd consider changing this a breaking change.
The text was updated successfully, but these errors were encountered: