Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the masked path integration test #227

Closed
utam0k opened this issue Aug 25, 2021 · 3 comments · Fixed by #276
Closed

Pass the masked path integration test #227

utam0k opened this issue Aug 25, 2021 · 3 comments · Fixed by #276
Assignees
@kmpzr
Labels
good first issue Good for newcomers

Comments

@utam0k
Copy link
Member

utam0k commented Aug 25, 2021 •
edited
Loading

Overview

Support masked pass
https://github.com/opencontainers/runtime-spec/blob/82ab996a5bf91804a440391bff43140b17bbadd4/config-linux.md#masked-paths

Goal

Pass the linux_masked_paths integration test in runtime-tools.
If you comment in this part and the test passes, you are all set.
https://github.com/containers/youki/blob/14856066b1a2bce63b8c55cb6cd16f60eab6ce02/integration_test.sh#L40

Reference
@utam0k utam0k added the good first issue Good for newcomers label Aug 25, 2021
@utam0k
Copy link
Member Author

utam0k commented Aug 25, 2021

It is more difficult than the other good first issues.

@kmpzr
Copy link
Contributor

kmpzr commented Aug 26, 2021

Hi @utam0k, I would like to work on this issue. Can you please assign it to me?

@utam0k
Copy link
Member Author

utam0k commented Aug 26, 2021

Hi @utam0k, I would like to work on this issue. Can you please assign it to me?

Sure!

@yihuaf yihuaf changed the title Pass the masked pass integration test Pass the masked path integration test Aug 27, 2021
@yihuaf yihuaf mentioned this issue Aug 31, 2021
Closed
9 tasks
@chenyukang chenyukang mentioned this issue Sep 6, 2021
Merged
@Furisto Furisto linked a pull request Sep 6, 2021 that will close this issue
Pass linux_masked_paths #276
Merged
@chenyukang chenyukang mentioned this issue Sep 6, 2021
Closed
@Furisto Furisto closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmpzr kmpzr

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass linux_masked_paths chenyukang/youki
3 participants
@kmpzr @utam0k @Furisto