-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass linux_process_apparmor_profile integration test #300
Comments
@Furisto may have already started developing this. |
@Furisto I see a lot of things on your plate. Let me know if I can help with this one or any other. |
I have started working on this but encountered some difficulties. Runc also fails this test on my system with the same error as my solution. Considering that I use the same distro as our CI, I expect the problem to manifest also there. I will continue to investigate this. Should I not be able to make progress until next monday, I will open this up to anyone else who is interested. |
Ok, got it. The test uses an apparmor profile that does not exist. We need to create it ourselves and install it before the test is run. |
Great find. May be manually verify it with installing the required apparmor profile and adds a comment to integration_test.sh? We will have our own integration framework done soon and will start porting the tests. I don't think it is worth it to put the fix into the CI workflow just so this integration test will pass on CI automatically. |
Fixed by #312 |
@yihuaf I want to track it so that I don't forget to create the original integration test. How about using this issue to complete that? |
@utam0k We certainly can. With that being said, I think we will have to port over all integration tests to our own framework, and this app armor test is only one of the 50ish tests. We also have a number of tests don't pass for runc and are commented out at the moment. May be we should create separate issues for the porting effort? I am sure we will not forget about this, since we have the list inside |
Overview
Need to pass the linux_process_apparmor_profile integration test
Goal
Pass the apparmor integration test in runtime-tools.
If you comment in this part and the test passes, you are all set.
https://github.com/containers/youki/blob/ef4b7932e80a91c67503325a76d322f0fc8f670b/integration_test.sh#L48
The text was updated successfully, but these errors were encountered: