-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoodleMagazine] fix extractor #11144
Conversation
The site now embeds the urls inside the webpage. So there is no need to download it from anywhere. just download the json directly.
Co-authored-by: bashonly <[email protected]>
it still don't work now File "yt_dlp\extractor\common.py", line 897, in _request_webpage |
@jzl543098871 This is a network error. It's not the fault of the extractor. I just confirmed that it still works just in case. NoodleMagazine denied your request. Perhaps your proxy was the problem. Or maybe, It was just a server issue. |
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
The site now embeds the urls of the videos inside a json in the webpage itself. So the previous method no longer works.
All we need now is to download the json from the webpage itself.
Fixes #9936
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?