Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoodleMagazine] fix extractor #11144

Merged
merged 2 commits into from
Oct 7, 2024
Merged

[NoodleMagazine] fix extractor #11144

merged 2 commits into from
Oct 7, 2024

Conversation

BallzCrasher
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

The site now embeds the urls of the videos inside a json in the webpage itself. So the previous method no longer works.
All we need now is to download the json from the webpage itself.

Fixes #9936

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

The site now embeds the urls inside the webpage. So there is no need to
download it from anywhere. just download the json directly.
@bashonly bashonly added NSFW site-bug Issue with a specific website labels Oct 2, 2024
yt_dlp/extractor/noodlemagazine.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-review PR needs a review label Oct 2, 2024
@bashonly bashonly removed the pending-review PR needs a review label Oct 2, 2024
@bashonly bashonly self-assigned this Oct 2, 2024
@jzl543098871
Copy link

it still don't work now
`E:\AA>yt-dlp -vU --proxy socks5://localhost:10808 --cookies E:\rule\nood\cookies.txt https://noodlemagazine.com/watch/-101261643_456240658
[debug] Command-line config: ['-vU', '--proxy', 'socks5://localhost:10808', '--cookies', 'E:\rule\nood\cookies.txt', 'https://noodlemagazine.com/watch/-101261643_456240658']
[debug] Encodings: locale cp936, fs utf-8, pref cp936, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version [email protected] from yt-dlp/yt-dlp [c6387ab] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k 25 Mar 2021)
[debug] exe versions: ffmpeg N-117345-g2705c0bd81-20241005 (setts), ffprobe N-117345-g2705c0bd81-20241005
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.35.5, urllib3-2.2.3, websockets-13.1
[debug] Proxy map: {'all': 'socks5://localhost:10808'}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1838 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: [email protected] from yt-dlp/yt-dlp
yt-dlp is up to date ([email protected] from yt-dlp/yt-dlp)
[NoodleMagazine] Extracting URL: https://noodlemagazine.com/watch/-101261643_456240658
[NoodleMagazine] -101261643_456240658: Downloading webpage
ERROR: [NoodleMagazine] -101261643_456240658: Unable to download webpage: HTTP Error 403: Forbidden (caused by <HTTPError 403: Forbidden>)
File "yt_dlp\extractor\common.py", line 741, in extract
File "yt_dlp\extractor\noodlemagazine.py", line 34, in _real_extract
File "yt_dlp\extractor\common.py", line 1200, in _download_webpage
File "yt_dlp\extractor\common.py", line 1151, in download_content
File "yt_dlp\extractor\common.py", line 961, in _download_webpage_handle
File "yt_dlp\extractor\common.py", line 910, in _request_webpage

File "yt_dlp\extractor\common.py", line 897, in _request_webpage
File "yt_dlp\YoutubeDL.py", line 4165, in urlopen
File "yt_dlp\networking\common.py", line 117, in send
File "yt_dlp\networking_helper.py", line 208, in wrapper
File "yt_dlp\networking\common.py", line 340, in send
File "yt_dlp\networking_requests.py", line 365, in _send
yt_dlp.networking.exceptions.HTTPError: HTTP Error 403: Forbidden`

@BallzCrasher
Copy link
Contributor Author

BallzCrasher commented Oct 6, 2024

yt_dlp.networking.exceptions.HTTPError: HTTP Error 403: Forbidden`

@jzl543098871 This is a network error. It's not the fault of the extractor. I just confirmed that it still works just in case. NoodleMagazine denied your request. Perhaps your proxy was the problem. Or maybe, It was just a server issue.

@bashonly bashonly merged commit ccb23e1 into yt-dlp:master Oct 7, 2024
6 checks passed
@BallzCrasher BallzCrasher deleted the noodlemagazinefix branch October 9, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSFW site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NoodleMagazine] Unable to extract player path
3 participants