Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soundcloud downloads do not have cover art #32496

Closed
5 tasks done
glencoe2004 opened this issue Aug 7, 2023 · 4 comments
Closed
5 tasks done

Soundcloud downloads do not have cover art #32496

glencoe2004 opened this issue Aug 7, 2023 · 4 comments

Comments

@glencoe2004
Copy link

Checklist

  • I'm reporting a broken site support
  • I've verified that I'm running youtube-dl version 2021.12.17
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://soundcloud.com/littlevmills/pokemon-zinnias-theme-epic-rock-coverfeat-richaadeb', '--cookies', 'cookies.txt']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 4.2.3
[debug] Proxy map: {}
[soundcloud] littlevmills/pokemon-zinnias-theme-epic-rock-coverfeat-richaadeb: Downloading info JSON
[soundcloud] 185391881: Downloading JSON metadata
[soundcloud] 185391881: Downloading webpage
[soundcloud] 185391881: Downloading JSON metadata
[soundcloud] 185391881: Downloading JSON metadata
[soundcloud] 185391881: Downloading JSON metadata
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'https://cf-media.sndcdn.com/meDi2X6fnlx1?Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiKjovL2NmLW1lZGlhLnNuZGNkbi5jb20vbWVEaTJYNmZubHgxKiIsIkNvbmRpdGlvbiI6eyJEYXRlTGVzc1RoYW4iOnsiQVdTOkVwb2NoVGltZSI6MTY5MTM5MTUwNH19fV19&Signature=bdZNQbTukhZm2ElIZ8dfiaHDm5enAFKs0x35L4g23FEoDn180fxWcxSxLcds-8nU6ZQiXMCLrW2OGdLl-tJJShCP4OPWPER1HvIG0E0Q7D6pShSm2ZzwpS1KpKgnz4VgOodpuq7OHe10bXM2agvOFNdONT-xnE-HmRLXlJPnTats10IPbYDTQIpD8ZHSfKIYSE2moQWvRuxe9rS2L-TbBIrHlhBmTQa2grw9LgaKWdawdnG7bMboqXxWZvtmZvpzJsixZEAVLLCpXKPYrIRU-BwqY8Iud6tHNcVXhpjRIP5IqVRiXajimiQCtR5W-DpujetfaKc3ltakIh1E~rv-Fw__&Key-Pair-Id=APKAI6TU7MMXM5DG6EPQ'
[download] Pokemon - Zinnia's Theme 'Epic Rock' Cover(Feat. RichaadEB)-185391881.mp3 has already been downloaded
[download] 100% of 9.69MiB

Description

The issue is that, as mentioned above, the downloaded file does not contain any album art (or any MP3 tags for that matter, although I'm unsure of if those are actually supported with SoundCloud.) Judging by PR #15117 , this was fixed in the past, but it's possible that a reversion has occurred somewhere that has broken the functionality.
Also, the issue is reproducible on both 2021.12.17 and 2023.08.07, and occurs whether or not a cookie file is supplied.
@nicolaasjan
Copy link

nicolaasjan commented Aug 7, 2023 •
edited
Loading

I have the embedded thumbnail here, but I must say I implemented pull request #30998 in my custom build.

ytd --ignore-config --embed-thumbnail --add-metadata -v https://soundcloud.com/littlevmills/pokemon-zinnias-theme-epic-rock-coverfeat-richaadeb
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--ignore-config', '--embed-thumbnail', '--add-metadata', '-v', 'https://soundcloud.com/littlevmills/pokemon-zinnias-theme-epic-rock-coverfeat-richaadeb']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2023.08.04
[debug] Lazy loading extractors enabled
[debug] Single file build
[debug] Python 3.8.10 (CPython x86_64 64bit) - Linux-5.4.0-155-generic-x86_64-with-glibc2.29 - OpenSSL 1.1.1f  31 Mar 2020 - glibc 2.31
[debug] exe versions: ffmpeg N-111355-g68e9d2835f-Nico-20230707, ffprobe N-111355-g68e9d2835f-Nico-20230707, phantomjs 2.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[soundcloud] littlevmills/pokemon-zinnias-theme-epic-rock-coverfeat-richaadeb: Downloading info JSON
[soundcloud] 185391881: Downloading JSON metadata
[soundcloud] 185391881: Downloading webpage
[soundcloud] 185391881: Downloading JSON metadata
[soundcloud] 185391881: Downloading JSON metadata
[soundcloud] 185391881: Downloading JSON metadata
[debug] Default format spec: bestvideo+bestaudio/best
[soundcloud] 185391881: Downloading thumbnail ...
[soundcloud] 185391881: Writing thumbnail to: Pokemon - Zinnia's Theme 'Epic Rock' Cover(Feat. RichaadEB)-185391881.jpg
[debug] Invoking downloader on 'https://cf-media.sndcdn.com/meDi2X6fnlx1?Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiKjovL2NmLW1lZGlhLnNuZGNkbi5jb20vbWVEaTJYNmZubHgxKiIsIkNvbmRpdGlvbiI6eyJEYXRlTGVzc1RoYW4iOnsiQVdTOkVwb2NoVGltZSI6MTY5MTM5NDc2NX19fV19&Signature=VKWB7DzVAo-mTd1hthUCkZnvZ6u7yoj0iLeqtbkKHLRQxbzJGy~g59dVlvPQb6~VDiKyEilbwUaSu-4bt7JIJlRn01sqjP572yM4Q1QsSWwy-7bBRwviLmNo12JIVAkxrOCMbZkvEzyHxTswjrphOHJmibKAKF9-f5MLsn-DeInvCsGRjA5Ti8pU8Eunnbs3gMuNy~D4WQzVlNyltrMbVD9ZLwh2Jg~F4vp1gZz~4i665k902wDFRCuosgb54ApNkGf-bchhx6WRb8Rh~bmJp9l1v-RPbz9ennQ6Ne7a0AhImnZsx5jIlsooFtRIyWwtlarVboIH~7StpsKgT8XYEQ__&Key-Pair-Id=APKAI6TU7MMXM5DG6EPQ'
[download] Destination: Pokemon - Zinnia's Theme 'Epic Rock' Cover(Feat. RichaadEB)-185391881.mp3
[download] 100% of 9.69MiB in 00:01
[ffmpeg] Adding metadata to 'Pokemon - Zinnia's Theme 'Epic Rock' Cover(Feat. RichaadEB)-185391881.mp3'
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i 'file:Pokemon - Zinnia'"'"'s Theme '"'"'Epic Rock'"'"' Cover(Feat. RichaadEB)-185391881.mp3' -c copy -metadata 'title=Pokemon - Zinnia'"'"'s Theme "Epic Rock" Cover(Feat. RichaadEB)' -metadata date=20150110 -metadata description= -metadata comment= -metadata purl=https://soundcloud.com/littlevmills/pokemon-zinnias-theme-epic-rock-coverfeat-richaadeb -metadata 'artist=Little V Mills' -metadata genre=Pokerock 'file:Pokemon - Zinnia'"'"'s Theme '"'"'Epic Rock'"'"' Cover(Feat. RichaadEB)-185391881.temp.mp3'
[ffmpeg] Adding thumbnail to "Pokemon - Zinnia's Theme 'Epic Rock' Cover(Feat. RichaadEB)-185391881.mp3"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i 'file:Pokemon - Zinnia'"'"'s Theme '"'"'Epic Rock'"'"' Cover(Feat. RichaadEB)-185391881.mp3' -i 'file:Pokemon - Zinnia'"'"'s Theme '"'"'Epic Rock'"'"' Cover(Feat. RichaadEB)-185391881.jpg' -c copy -map 0 -map 1 -metadata:s:v 'title="Album cover"' -metadata:s:v 'comment="Cover (Front)"' 'file:Pokemon - Zinnia'"'"'s Theme '"'"'Epic Rock'"'"' Cover(Feat. RichaadEB)-185391881.temp.mp3'

MediaInfo:

General
Complete name                            : /home/nico/Bureaublad/Pokemon - Zinnia's Theme 'Epic Rock' Cover(Feat. RichaadEB).mp3
Format                                   : MPEG Audio
File size                                : 10.7 MiB
Duration                                 : 4 min 13 s
Overall bit rate mode                    : Variable
Overall bit rate                         : 320 kb/s
Writing library                          : Lavf60.10.100
Cover                                    : Yes
Cover description                        : "Album cover"
Cover MIME                               : image/jpeg
TSS                                      : Logic 10.0.7
iTunNORM                                 :  00002DE6 00002F3A 00009C7F 0000A23D 0001ED92 0001DCD6 00008B28 00008A04 00010B8D 0002E087
iTunSMPB                                 :  00000000 00000210 00000B5E 0000000000AADC12 00000000 009AE510 00000000 00000000 00000000 00000000 00000000 00000000

Audio
Format                                   : MPEG Audio
Format version                           : Version 1
Format profile                           : Layer 3
Format settings                          : Joint stereo / MS Stereo
Duration                                 : 4 min 13 s
Bit rate mode                            : Variable
Bit rate                                 : 320 kb/s
Channel(s)                               : 2 channels
Sampling rate                            : 44.1 kHz
Frame rate                               : 38.281 FPS (1152 SPF)
Compression mode                         : Lossy
Stream size                              : 9.69 MiB (91%)

FFprobe detects more metadata:

  Metadata:
    TSS             : Logic 10.0.7
    iTunNORM        :  00002DE6 00002F3A 00009C7F 0000A23D 0001ED92 0001DCD6 00008B28 00008A04 00010B8D 0002E087
    iTunSMPB        :  00000000 00000210 00000B5E 0000000000AADC12 00000000 009AE510 00000000 00000000 00000000 00000000 00000000 00000000
    title           : Pokemon - Zinnia's Theme "Epic Rock" Cover(Feat. RichaadEB)
    date            : 20150110
    purl            : https://soundcloud.com/littlevmills/pokemon-zinnias-theme-epic-rock-coverfeat-richaadeb
    artist          : Little V Mills
    genre           : Pokerock
    encoder         : Lavf60.10.100
  Duration: 00:04:13.99, start: 0.011995, bitrate: 352 kb/s
  Stream #0:0: Audio: mp3, 44100 Hz, stereo, fltp, 320 kb/s
    Metadata:
      encoder         : Lavf
  Stream #0:1: Video: mjpeg (Baseline), yuvj444p(pc, bt470bg/unknown/unknown), 1920x1080, 90k tbr, 90k tbn (attached pic)
    Metadata:
      title           : "Album cover"
      comment         : Other

@glencoe2004
Copy link
Author

glencoe2004 commented Aug 7, 2023 •
edited
Loading 

'--embed-thumbnail', '--add-metadata'

Y'know, me not using those flags was probably the issue to begin with. Not downloading metadata and the album art by default is an... interesting choice, I must say.

Either way, your fork with those flags works perfectly. Thanks.

@nicolaasjan
Copy link

I should have noticed these flags were missing in your verbose log...

Guess you can close the issue now?

@glencoe2004
Copy link
Author

Seems that way. Thanks for all the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolaasjan @glencoe2004