Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fogshadows graphical glitch. #447

Open
roboman2444 opened this issue Nov 20, 2016 · 5 comments
Open

Fogshadows graphical glitch. #447

roboman2444 opened this issue Nov 20, 2016 · 5 comments
Labels
bug some feature is broken renderer

Comments

@roboman2444
Copy link
Contributor

This happens when looking straight up through a shadow.

Entire gallary: https://imgur.com/a/w1oe7

@yvt yvt added bug some feature is broken renderer labels Nov 20, 2016
@VelocityRa
Copy link
Collaborator

Thank you for the report.
Can you provide more information, for example, what platform are you on and what are your specs (GPU mainly) ?

@roboman2444
Copy link
Contributor Author

Debian testing
Nvidia 770 4gb
Nvidia prop drivers version 370.28

@yvt
Copy link
Owner

yvt commented Dec 9, 2016

This bug was introduced in the commit 4047b61 when the equation of the fog density was modified to match the original client.

@pielover88888
Copy link

pielover88888 commented Dec 14, 2016

I am able to reproduce on Intel HD 4000 igpu on Windows 7

@feikname feikname added this to the 0.1.1 milestone Dec 26, 2016
@roboman2444
Copy link
Contributor Author

The offending line is
voxelDistanceFactor *= length(viewDir.xy) / length(viewDir); // remove vertical fog

or line 62 in Resources/Shaders/PostFilters/Fog.fs
Removing that lines fixes the weird artifacts, but I am not sure how much it matters for "correct" fog.

Also, I do believe that line should be AFTER
float screenVoxelDistance = screenDistance * voxelDistanceFactor; (line 68)
since it should only be modifying the density of the fog, not the raymarching sample distance and length, but I am not entirely sure.

@yvt yvt removed this from the 0.1.1 milestone Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug some feature is broken renderer
Projects
None yet
Development

No branches or pull requests

5 participants