From 33829635f42b982d77393446ffad1c5663947e96 Mon Sep 17 00:00:00 2001 From: Alexander Yastrebov Date: Fri, 12 Jan 2024 15:07:27 +0100 Subject: [PATCH] eskip: add comment test cases for ParsePredicates Add test cases from #2755 discovered by fuzzing. Signed-off-by: Alexander Yastrebov --- eskip/eskip_test.go | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/eskip/eskip_test.go b/eskip/eskip_test.go index ab141f6b4c..afb2729ac3 100644 --- a/eskip/eskip_test.go +++ b/eskip/eskip_test.go @@ -386,16 +386,22 @@ func TestPredicateParsing(t *testing.T) { }, { title: "star notation", input: `*`, + }, { + title: "comment fuzz 1", + input: `///`, + expected: nil, + }, { + title: "comment fuzz 2", // "\x2f\x2f..." == "//..." + input: "\x2f\x2f\x00\x00\x00\xe6\xfe\x00\x00\x2f\x00\x00\x00\x00\x00\x00\x00\xe6\xfe\x00\x00\x2f\x00\x00\x00\x00", + expected: nil, }} { t.Run(test.title, func(t *testing.T) { p, err := ParsePredicates(test.input) if err == nil && test.fail { - t.Error("failed to fail") - return + t.Fatalf("failed to fail: %#v", p) } else if err != nil && !test.fail { - t.Error(err) - return + t.Fatal(err) } if !cmp.Equal(p, test.expected) {