-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add schema example for encrypted data-frames #715
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great example in the notebook!
For the code in the nb, could you change the
schema = {
"index": {
"client_1": 1,
"client_2": 2,
"client_3": 3,
"client_4": 4,
to use a generator to make it shorter?
The notebook text must be changed:
- don't use the first person
- explain limitations and future fixes in a better manner
48c76d2
to
a7b33c6
Compare
Coverage passed ✅Coverage details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes
refs https://github.com/zama-ai/concrete-ml-internal/issues/4376