Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add schema example for encrypted data-frames #715

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

RomanBredehoft
Copy link
Contributor

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner June 5, 2024 15:49
@cla-bot cla-bot bot added the cla-signed label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

⚠️ Known flaky tests have been rerun ⚠️

One or several tests initially failed but were identified as known flaky. tests. Therefore, they have been rerun and passed. See below for more details.

Failed tests details

Known flaky tests that initially failed:

  • tests/torch/test_brevitas_qat.py::test_brevitas_tinymnist_cnn[True-True-3]

Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example in the notebook!

For the code in the nb, could you change the

schema = {
    "index": {
        "client_1": 1,
        "client_2": 2,
        "client_3": 3,
        "client_4": 4,

to use a generator to make it shorter?

The notebook text must be changed:

  • don't use the first person
  • explain limitations and future fixes in a better manner

@RomanBredehoft RomanBredehoft force-pushed the docs/add_data_frame_schema_example_4376 branch from 48c76d2 to a7b33c6 Compare June 7, 2024 14:10
Copy link

github-actions bot commented Jun 7, 2024

Coverage passed ✅

Coverage details

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    7799      0   100%

59 files skipped due to complete coverage.

Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@RomanBredehoft RomanBredehoft merged commit b174509 into main Jun 11, 2024
12 checks passed
@RomanBredehoft RomanBredehoft deleted the docs/add_data_frame_schema_example_4376 branch June 11, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants