Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18 lint errors #58

Open
matthiasgeihs opened this issue Jan 15, 2025 · 1 comment
Open

18 lint errors #58

matthiasgeihs opened this issue Jan 15, 2025 · 1 comment

Comments

@matthiasgeihs
Copy link

The template nicely provides tools for linting. However, when running pnpm lint:ts on the freshly checked out template, I'm getting a lot of errors, see below. Would be nice if the template code didn't throw lint errors, because otherwise it will be hard to distinguish these from lint errors of my code. This basically makes linting unusable.

% pnpm lint:ts

> @zama-ai/[email protected] lint:ts /Users/matthias/tmp/fhevm/fhevm-auction
> eslint .


/Users/matthias/tmp/fhevm/fhevm-auction/test/asyncDecrypt.ts
  123:29  error  A `require()` style import is forbidden                 @typescript-eslint/no-require-imports
  148:9   error  'encodedData' is never reassigned. Use 'const' instead  prefer-const
  149:9   error  'calldata' is never reassigned. Use 'const' instead     prefer-const

/Users/matthias/tmp/fhevm/fhevm-auction/test/coprocessorUtils.ts
   14:5   error  'counterRand' is assigned a value but never used  @typescript-eslint/no-unused-vars
  187:16  error  'e' is defined but never used                     @typescript-eslint/no-unused-vars
  570:7   error  Unexpected lexical declaration in case block      no-case-declarations
  571:7   error  Unexpected lexical declaration in case block      no-case-declarations
  572:7   error  Unexpected lexical declaration in case block      no-case-declarations
  785:7   error  Expected a 'break' statement before 'case'        no-fallthrough

/Users/matthias/tmp/fhevm/fhevm-auction/test/fhevmjsMocked.ts
  142:23  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/matthias/tmp/fhevm/fhevm-auction/test/mockedSetup.ts
  17:23  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  20:24  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  23:23  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  26:25  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  29:30  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports
  32:27  error  A `require()` style import is forbidden  @typescript-eslint/no-require-imports

/Users/matthias/tmp/fhevm/fhevm-auction/test/reencrypt.ts
  164:12  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/matthias/tmp/fhevm/fhevm-auction/test/signers.ts
  6:6  error  'AccountNames' is defined but never used  @typescript-eslint/no-unused-vars
@matthiasgeihs
Copy link
Author

Plus, when opening the files, I'm also getting typescript errors like the following in mockedSetup.ts, and others.

await kms.connect(zero).initialize(OneAddress);

Property 'initialize' does not exist on type 'Ownable'. ts(2339)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant