Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Mypy errors in v3 branch #1593

Closed
2 tasks done
jhamman opened this issue Dec 7, 2023 · 3 comments
Closed
2 tasks done

Resolve Mypy errors in v3 branch #1593

jhamman opened this issue Dec 7, 2023 · 3 comments
Assignees
Labels
chore help wanted Issue could use help from someone with familiarity on the topic types
Milestone

Comments

@jhamman
Copy link
Member

jhamman commented Dec 7, 2023

The v3 branch needs some Mypy attention. As expected, our port of the zarrita code (see #1584) has left a number of mypy errors that would be great to resolve.

This ticket can be closed when:

  • we have CI running against the v3 codebase
  • we have zero mypy errors when checked in a github action

Marking this as help-wanted!

@jhamman jhamman added help wanted Issue could use help from someone with familiarity on the topic V3 chore types labels Dec 7, 2023
@jhamman
Copy link
Member Author

jhamman commented Feb 6, 2024

This is feeling like a fairly high priority to start ticking off. For now, I've disabled the mypy checks in pre-commit (#1649) but this should be a short lived state.

@DahnJ
Copy link
Contributor

DahnJ commented Mar 4, 2024

I wanted to get into zarr a little and this issue had "help wanted" tag, so I picked it up here: #1692

I made a few choices in fixing some of the issues, hope it helps more than adds noise 🙂

@jhamman jhamman moved this to Todo in Zarr-Python - 3.0 Apr 5, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 5, 2024
@jhamman jhamman moved this from Todo to In Progress in Zarr-Python - 3.0 Apr 5, 2024
@jhamman
Copy link
Member Author

jhamman commented May 17, 2024

closed by #1692 and lots more work by @dstansby. See #1783 for ongoing work on this topic.

@jhamman jhamman closed this as completed May 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Zarr-Python - 3.0 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore help wanted Issue could use help from someone with familiarity on the topic types
Projects
Status: Done
Development

No branches or pull requests

2 participants